Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedreader change icon behavior #9396

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Speedreader change icon behavior #9396

merged 3 commits into from
Jul 12, 2021

Commits on Jul 12, 2021

  1. speedreader: Change how the icon behaves 

    After a meeting with the Speedreader team, Raf suggested we have too
much going on in the omnibox, and that we ought to kill the labels.
Instead of indicating page state via labels, we do so with different
icons. Icon vector change is triggered from the Update() method.

We get to delete lots of code now that we don't need to bother with
labels :)

Resolves brave/brave-browser#9262
    Kevin Kuehler committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    4b7ae7a View commit details
    Browse the repository at this point in the history

  2. speedreader: icon: Fix accessible text 

    In 85a5f8b we removed the label from the Speedreader icon. To make up
for this, we need more descriptive accessible text. This is taken from
the figma document linked in the issue.

Resolves brave/brave-browser#16881
    Kevin Kuehler committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    1256137 View commit details
    Browse the repository at this point in the history

  3. speedreader: icon: Delete dead code

    Kevin Kuehler committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    ab1af8e View commit details
    Browse the repository at this point in the history