Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and upload silent and untagged Windows Omaha installers #974

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Create and upload silent and untagged Windows Omaha installers #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63993bb
Create and upload silent and untagged Windows Omaha installers
mbacchi Nov 28, 2018
53b718c
fixed linting and pep8 issues
mihaiplesa Nov 28, 2018
80c4acf
increased line length to 120 for pep8
mihaiplesa Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ deps = {
"vendor/requests": "https://github.com/kennethreitz/requests@e4d59bedfd3c7f4f254f4f5d036587bcd8152458",
"vendor/boto": "https://github.com/boto/boto@f7574aa6cc2c819430c1f05e9a1a1a666ef8169b",
"vendor/python-patch": "https://github.com/svn2github/python-patch@a336a458016ced89aba90dfc3f4c8222ae3b1403",
"vendor/omaha": "https://github.com/brave/omaha.git@dc2582d63a5b92dd39bf7bfd07612e501e133143",
"vendor/omaha": "https://github.com/brave/omaha.git@e4263050ed24e92f4d3ed0b6874538f811011c5b",
"vendor/sparkle": "https://github.com/brave/Sparkle.git@c0759cce415d7c0feae45005c8a013b1898711f0",
"vendor/bat-native-ledger": "https://github.com/brave-intl/bat-native-ledger@f72aad5f4e85a50980ee657b51da3df054db0b47",
"vendor/bat-native-rapidjson": "https://github.com/brave-intl/bat-native-rapidjson.git@86aafe2ef89835ae71c9ed7c2527e3bb3000930e",
Expand Down
4 changes: 4 additions & 0 deletions build/config.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ if (is_win) {
}
brave_installer_exe = "brave_installer$brave_underline_full_version.exe"
brave_stub_installer_exe = "BraveBrowser$_channel" + "Setup$_arch$brave_underline_full_version.exe"
brave_silent_stub_installer_exe = "BraveBrowserSilent$_channel" + "Setup$_arch$brave_underline_full_version.exe"
brave_untagged_stub_installer_exe = "BraveBrowserUntagged$_channel" + "Setup$_arch$brave_underline_full_version.exe"
brave_standalone_installer_exe = "BraveBrowserStandalone$_channel" + "Setup$_arch$brave_underline_full_version.exe"
brave_silent_installer_exe = "BraveBrowserStandaloneSilent$_channel" + "Setup$_arch$brave_underline_full_version.exe"
brave_untagged_installer_exe = "BraveBrowserStandaloneUntagged$_channel" + "Setup$_arch$brave_underline_full_version.exe"
} else if (is_mac) {
brave_exe = "$chrome_product_full_name.app"
brave_dmg = "$chrome_product_full_name.dmg"
Expand Down
2 changes: 1 addition & 1 deletion components/brave_sync/ui/brave_sync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ window.cr.define('sync_ui_exports', function () {
getActions().onLogMessage(message)
}

function syncSetupError(error: string) {
function syncSetupError (error: string) {
alert('Sync setup error: ' + error)
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"lint": "tslint --project tsconfig.json 'components/**/*.{ts,tsx}'",
"pep8": "pycodestyle -r script",
"pep8": "pycodestyle --max-line-length 120 -r script",
"web-ui-gen-grd": "node components/webpack/gen-webpack-grd",
"web-ui": "webpack --config components/webpack/webpack.config.js --progress --colors",
"test-unit": "jest -t",
Expand Down
Loading