Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr93 followup] Fixes profile picker - hides "Set up" page. #9789

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#17552

Overrides call to AccountConsistencyModeManager::IsDiceSignInAllowed in
profile_picker_ui.cc to return false so that the page isn't shown. There
is a feature flag (features::kSignInProfileCreation) to do the same, but
the flag is already removed in cr94, so this should be a more durable
solution.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner August 19, 2021 16:15
@mkarolin mkarolin self-assigned this Aug 19, 2021
Fixes brave/brave-browser#17552

Overrides call to AccountConsistencyModeManager::IsDiceSignInAllowed in
profile_picker_ui.cc to return false so that the page isn't shown. There
is a feature flag (features::kSignInProfileCreation) to do the same, but
the flag is already removed in cr94, so this should be a more durable
solution.
@mkarolin mkarolin force-pushed the maxk-cr93fu-profile-picker-fix branch from fff063f to b14babe Compare August 19, 2021 16:57
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit e398b7b into master Aug 20, 2021
@mkarolin mkarolin deleted the maxk-cr93fu-profile-picker-fix branch August 20, 2021 12:47
@mkarolin mkarolin added this to the 1.30.x - Nightly milestone Aug 20, 2021
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.30.39 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Brave
  3. clicked
  4. clicked Create a New Profile

Confirmed the resulting dialog was the Customize your Brave profile one we're used to:

Screen Shot 2021-08-20 at 5 18 18 PM

mkarolin added a commit that referenced this pull request Aug 24, 2021
[cr93 followup] Fixes profile picker - hides "Set up" page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cr93 followup]: Hide "Set up new Brave profile" page when adding a new profile in profile picker.
5 participants