This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
disallow click event when stats are 0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
shields-disabled-when-0
branch
3 times, most recently
from
e46402d
to
608eb02
Compare
|
rebased |
yrliou
approved these changes
Nov 6, 2018
yrliou
suggested changes
Nov 6, 2018
cezaraugusto
force-pushed
the
shields-disabled-when-0
branch
from
608eb02
to
22838da
Compare
yrliou
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes brave/brave-browser#1957
Test Plan:
when stat is 0 you shouldn't be able to see resources blocked list