Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Playlist] - Sometimes adding media embedded in an iFrame won't work. #3923

Closed
Brandon-T opened this issue Jul 13, 2021 · 1 comment · Fixed by #3924
Closed

[Playlist] - Sometimes adding media embedded in an iFrame won't work. #3923

Brandon-T opened this issue Jul 13, 2021 · 1 comment · Fixed by #3924

Comments

@Brandon-T
Copy link
Collaborator

Description:

Sometimes adding media through gesture recognizer won't work when embedded in an iFrame.

Steps to Reproduce

  1. Go to: https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_video
  2. Change: <video width="400" controls> to <video width="400" controls playsinline>
  3. Hit "Run" button.
  4. Long-Press on the video to add it to playlist.

Actual result:

  • Video won't be added to playlist.
  • Popup won't show "Add to Brave Playlist".

Expected result:

  • Should show popup to "Add to Brave Playlist".

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced

Brave Version:
1.27

Device details:
Any

Website problems only:
N/A

Additional Information

Only happens for videos where the content offset of the frame itself is > 0 in either direction relative to the current page.

@srirambv
Copy link
Contributor

srirambv commented Jul 27, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.29(21.07.20.16)

  • Verified steps from issue description
  • Verified able to add videos to playlist
iPhone.XR.iframe.Playlist.MP4

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.29(21.07.20.16)

  • Verified steps from issue description
  • Verified able to add videos to playlist
iPhone.7+.iframe.Playlist.MP4

Verification passed on iPad Pro with iOS 14.6 running 1.29(21.07.20.16)

  • Verified steps from issue description
  • Verified able to add videos to playlist
iPad.Pro.iframe.Playlist.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.