Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3923 - Playlist Gesture Recognizer within iFrame #3924

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Jul 13, 2021

  • Makes playlist video detection more robust when iFrames and gestures are involved.

Summary of Changes

This pull request fixes #3923

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Included in the ticket.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.29 milestone Jul 13, 2021
@iccub iccub merged commit 224602e into development Jul 15, 2021
@iccub iccub deleted the bugfix/PlaylistFrameGestureRecognizing branch July 15, 2021 13:15
KacperWybranski pushed a commit to KacperWybranski/brave-ios that referenced this pull request Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playlist] - Sometimes adding media embedded in an iFrame won't work.
4 participants