Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Truncate URL display from the left #6190

Closed
diracdeltas opened this issue Oct 14, 2022 · 4 comments · Fixed by #6802
Closed

Truncate URL display from the left #6190

diracdeltas opened this issue Oct 14, 2022 · 4 comments · Fixed by #6802

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Oct 14, 2022

@diracdeltas diracdeltas changed the title Origin-only URL display Truncate URL display from the left Oct 14, 2022
@diracdeltas diracdeltas added the priority/P3 The next thing for us to work on. label Oct 14, 2022
@diracdeltas
Copy link
Member Author

@kylehickinson can we get someone assigned to this?

@kylehickinson kylehickinson self-assigned this Nov 10, 2022
@kylehickinson
Copy link
Collaborator

@diracdeltas just to confirm, is this issue for the truncation from left with the current full URL implementation? The spec listed in the issue is for hiding the rest of the url and only displaying the origin when not in edit mode

@diracdeltas
Copy link
Member Author

@kylehickinson we can probably take this in stages. for now i'd be happy if just the behavior on iOS matched android so the TLD+1 is always visible and gets truncated from the left if it's too long

kylehickinson added a commit that referenced this issue Nov 10, 2022
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Nov 11, 2022
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Nov 18, 2022
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Jan 19, 2023
Also fixes a bug when a really long URL had a path in it and would truncate the last letter in the TLD
kylehickinson added a commit that referenced this issue Jan 19, 2023
Also fixes a bug when a really long URL had a path in it and would truncate the last letter in the TLD
@iccub iccub added this to the 1.48 milestone Feb 2, 2023
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 & iPad (9th Gen) running iOS 16.2, iPadOS 15.6.1 respectively using version 1.48 (23.2.10.14)

Based on Test plan in #6190 (comment):

  • Verified URL is truncated from the left when loading test page 1 and test page 2
  • Verified long submains are truncated with and without path
  • Verified URL is truncated using HTTP
with path without path
IMG_4468 IMG_4470
IMG_0110 IMG_0111 2

kylehickinson added a commit that referenced this issue Nov 9, 2023
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Nov 13, 2023
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Nov 14, 2023
This change matches Chrome iOS and Safari where the full URL is not displayed
kylehickinson added a commit that referenced this issue Nov 14, 2023
This change matches Chrome iOS and Safari where the full URL is not displayed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.