Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6190: Add leading fade when truncating URL bar text #6802

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

kylehickinson
Copy link
Collaborator

Also fixes a bug when a really long URL had a path in it and would truncate the last letter in the TLD

Summary of Changes

This pull request fixes #6190

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Screenshots:

With Path Without Path
Simulator Screen Shot - iPhone 14 Pro - 2023-01-19 at 14 01 08 Simulator Screen Shot - iPhone 14 Pro - 2023-01-19 at 14 02 03

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

Also fixes a bug when a really long URL had a path in it and would truncate the last letter in the TLD
@kylehickinson kylehickinson requested a review from a team January 19, 2023 19:27
@kylehickinson kylehickinson added this to the 1.48 milestone Jan 19, 2023
@kylehickinson kylehickinson merged commit 339a452 into development Jan 19, 2023
@kylehickinson kylehickinson deleted the ios-url-bar-truncation branch January 19, 2023 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate URL display from the left
2 participants