You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2024. It is now read-only.
Still the metrics are not shown, the step 4 is bug, in desktop the metrics are shown with response value 0
Open any site (e.g cnn.com)
Open the shield panel for cnn.com
Disable "Block Cross-Site Trackers" switch via shield panel
Open the local state file and do refresh
Remove app from memory and relaunch
The metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value is 1 in the local state file.
Note: The metrics Brave.Shields.DomainAdsSettingsBelowGlobal response is 1 which is correct and expected. But the metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value is also 1 which is wrong as I have not updated the Adblocking settings to "Aggressive", moreover iOS doesn't have any option to set the local shield settings to "Aggressive" via panel
Actual result:
Incorrect response value for DomainAdsSettingsAboveGlobal metrics
Example
Example
Expected result:
The metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value should be 0
Reproduces how often: [Easily reproduced, Intermittent Issue]
Verification PASSED on iPhone 8 version 16.1.1 running Brave Dev 1.46 (22.12.7.22)
Verified the STR from the decsription and ensured Brave.Shields.DomainAdsSettingsBelowGlobal =0 and Brave.Shields.DomainAdsSettingsAboveGlobal =0 are reported in local state file
Example
Example
Verified that when "Block Cross-Site Trackers" switch is disabled via shield panel for any site, the metrics Brave.Shields.DomainAdsSettingsBelowGlobal =1 and Brave.Shields.DomainAdsSettingsAboveGlobal =0 as expected
Description:
Incorrect response value for
DomainAdsSettingsAboveGlobal
metricsSteps to Reproduce
Brave.Shields.DomainAdsSettingsBelowGlobal
andBrave.Shields.DomainAdsSettingsAboveGlobal
are NOT shown in local state file (Logged TheDomainAdsSettingsBelowGlobal
andDomainAdsSettingsAboveGlobal
are not reported in local state file until the adblocking settings is disabled via shield panel #6592)0
Brave.Shields.DomainAdsSettingsAboveGlobal
response value is1
in the local state file.Note: The metrics
Brave.Shields.DomainAdsSettingsBelowGlobal
response is1
which is correct and expected. But the metricsBrave.Shields.DomainAdsSettingsAboveGlobal
response value is also1
which is wrong as I have not updated the Adblocking settings to "Aggressive", moreover iOS doesn't have any option to set the local shield settings to "Aggressive" via panelActual result:
Incorrect response value for
DomainAdsSettingsAboveGlobal
metricsExpected result:
The metrics
Brave.Shields.DomainAdsSettingsAboveGlobal
response value should be0
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy
Brave Version:
1.46 (22.12.6.19)
Device details:
iPhone 8 - 16.1.1
Website problems only:
Additional Information
cc: @brave/qa-team @kylehickinson @anthonypkeane
The text was updated successfully, but these errors were encountered: