Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Incorrect response value for DomainAdsSettingsAboveGlobal metrics #6591

Closed
GeetaSarvadnya opened this issue Dec 7, 2022 · 1 comment · Fixed by #6595
Closed

Incorrect response value for DomainAdsSettingsAboveGlobal metrics #6591

GeetaSarvadnya opened this issue Dec 7, 2022 · 1 comment · Fixed by #6595

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 7, 2022

Description:

Incorrect response value for DomainAdsSettingsAboveGlobal metrics

Steps to Reproduce

  1. Clean profile 1.46 (22.12.6.19)
  2. Open local state file via Settings
  3. The metrics Brave.Shields.DomainAdsSettingsBelowGlobal and Brave.Shields.DomainAdsSettingsAboveGlobal are NOT shown in local state file (Logged The DomainAdsSettingsBelowGlobal and DomainAdsSettingsAboveGlobal are not reported in local state file until the adblocking settings is disabled via shield panel #6592)
  4. Remove app from memory and relaunch
  5. Still the metrics are not shown, the step 4 is bug, in desktop the metrics are shown with response value 0
  6. Open any site (e.g cnn.com)
  7. Open the shield panel for cnn.com
  8. Disable "Block Cross-Site Trackers" switch via shield panel
  9. Open the local state file and do refresh
  10. Remove app from memory and relaunch
  11. The metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value is 1 in the local state file.

Note: The metrics Brave.Shields.DomainAdsSettingsBelowGlobal response is 1 which is correct and expected. But the metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value is also 1 which is wrong as I have not updated the Adblocking settings to "Aggressive", moreover iOS doesn't have any option to set the local shield settings to "Aggressive" via panel

Actual result:

Incorrect response value for DomainAdsSettingsAboveGlobal metrics

Example Example
IMG_3246 IMG_3247

Expected result:
The metrics Brave.Shields.DomainAdsSettingsAboveGlobal response value should be 0

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy
Brave Version:

1.46 (22.12.6.19)
Device details:
iPhone 8 - 16.1.1

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @brave/qa-team @kylehickinson @anthonypkeane

@GeetaSarvadnya
Copy link
Author

Verification PASSED on iPhone 8 version 16.1.1 running Brave Dev 1.46 (22.12.7.22)

  • Verified the STR from the decsription and ensured Brave.Shields.DomainAdsSettingsBelowGlobal =0 and Brave.Shields.DomainAdsSettingsAboveGlobal =0 are reported in local state file
Example Example
IMG_3261 IMG_3262
  • Verified that when "Block Cross-Site Trackers" switch is disabled via shield panel for any site, the metrics Brave.Shields.DomainAdsSettingsBelowGlobal =1 and Brave.Shields.DomainAdsSettingsAboveGlobal =0 as expected
Example Example
IMG_3264 IMG_3265

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants