Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6591, Fix #6592: Shields P3A question fixes #6595

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fix #6591, Fix #6592: Shields P3A question fixes #6595

merged 2 commits into from
Dec 7, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #6591
This pull request fixes #6592

Merge by rebase

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.46 milestone Dec 7, 2022
@kylehickinson kylehickinson requested a review from a team December 7, 2022 15:45
@kylehickinson kylehickinson enabled auto-merge (rebase) December 7, 2022 15:50
@kylehickinson kylehickinson mentioned this pull request Dec 7, 2022
Closed
@kylehickinson kylehickinson merged commit f9fabe2 into development Dec 7, 2022
@kylehickinson kylehickinson deleted the p3a-shields-answers branch December 7, 2022 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soner-yuksel soner-yuksel soner-yuksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46
2 participants
@kylehickinson @soner-yuksel