Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Please update the default search provider list for South Korea #6912

Closed
anthonypkeane opened this issue Feb 8, 2023 · 3 comments · Fixed by #7668
Closed

Please update the default search provider list for South Korea #6912

anthonypkeane opened this issue Feb 8, 2023 · 3 comments · Fixed by #7668
Assignees
@iccub
Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.56

Comments

@anthonypkeane
Copy link

Description:

Per: brave/brave-browser#18855

Please add the follow search engines for South Korea and update the default.

Naver & Daum

Please make Naver the default for new users.

Naver
210639164-f38566f9-87a0-48a2-98df-50f148eea080

Daum
210812848-9275a614-cee8-4429-af99-b56be70a483f
@anthonypkeane
Copy link
Author

@iccub can we line this up in 1.53, it is live on Android/Desktop now. Thanks

@iccub
Copy link
Contributor

iccub commented Jun 28, 2023

sure

@iccub iccub added this to the 1.53 milestone Jun 28, 2023
iccub added a commit that referenced this issue Jun 30, 2023
@iccub
Fix #6912: Add new search engines for South Korea region
e8e4d0e
@iccub iccub self-assigned this Jun 30, 2023
@iccub iccub mentioned this issue Jun 30, 2023
Merged
11 tasks
iccub added a commit that referenced this issue Jul 4, 2023
@iccub
Fix #6912: Add new search engines for South Korea region (#7668)
0a983e0
@hffvld
Copy link
Collaborator

hffvld commented Jul 20, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)
New user flow - PASS

STEPS:

  1. Change Region to South Korea in device settings
  2. Fresh install and then launch Brave
  3. Three-dot menu > Settings > Search Engines > Verify
  4. Open Standard Tab > Verify
  5. Go back and open Private Tab > Verify
  6. Go back and open NTP > Make a search request > Verify
  7. Repeat the same for Private Tab > Verify

ACTUAL RESULTS:

  • Verified that Naver and Daum SE were added to the South Korean region
  • Verified that default SE for South Koria is set to Naver for both Standard Tab and Private Tab
  • Verified that search results are shown with the correct SE
  • Verified that Naver and Daum avatar icons are shown in the keyboard's search bar
1 2 3 4
1 2 3 4
SE.new.mov
Upgraded user flow - PASS

STEPS:

  1. Change Region to South Korea in device settings
  2. Have Brave 1.52 installed on a device > Confirm that there are no Naver or Daum SE in Brave settings
  3. Upgrade to Brave 1.56 and then launch the app
  4. Three-dot menu > Settings > Search Engines > Verify
  5. Open Standard Tab > Verify
  6. Go back and open Private Tab > Verify
  7. Go back and open NTP > Make a search request > Verify
  8. Repeat the same for Private Tab > Verify

ACTUAL RESULTS:

  • Verified that Naver and Daum SE were added to the South Korean region
  • Verified that default SE for South Koria is set to Naver for both Standard Tab and Private Tab
  • Verified that search results are shown with the correct SE
  • Verified that Naver and Daum avatar icons are shown in the keyboard's search bar
SE.upgrade.mov

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#6912: Add new search engines for South Korea regi…
9ce3e9f 
…on (brave/brave-ios#7668)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #6912: Add new search engines for South Korea region brave/brave-ios
4 participants
@iccub @anthonypkeane @Uni-verse @hffvld