Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6912: Add new search engines for South Korea region #7668

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jun 30, 2023

Summary of Changes

This pull request fixes #6912

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Set your device region to South Korea.
Verify that Naver is set as default engine.
Verify that Daum search engine is available.
Verify that both search engines work and their search suggestions work as well
Verify that these search engines do not show for non South Korea region users

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from simonhong June 30, 2023 17:00
@iccub iccub requested a review from a team as a code owner June 30, 2023 17:00
@iccub iccub added this to the 1.53 milestone Jun 30, 2023
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@iccub iccub merged commit 0a983e0 into development Jul 4, 2023
@iccub iccub deleted the bugfix/6912 branch July 4, 2023 13:14
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update the default search provider list for South Korea
3 participants