Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Reorder causes folders to show up in a weird format on each device #860

Closed
srirambv opened this issue Feb 6, 2019 · 3 comments
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2019

Description:

There is a weird bug here when bookmarks/folders are reordered on one device
Device 1: iPhone 7+ sync chain creator with existing bookmarks
Device 2: iPad Pro created empty bookmark folder post sync
Reorder all bookmark folders to the end post sync causes the following

Device 1:
image from ios
Device 2:
file 5

Closing the bookmark tray and reopening it shows correctly. Also some times it messes up the ordering and folders start showing up with weird colours

Expected result:
Order should be same on both devices

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Additional information
#772

@srirambv srirambv added this to the 1.8 milestone Feb 6, 2019
@srirambv srirambv removed this from the 1.8 milestone Feb 8, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Feb 11, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Feb 11, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Mar 5, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Mar 5, 2019
@iccub
Copy link
Contributor

iccub commented Mar 6, 2019

Fixed via via 09f57cb

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 27, 2019

Verification passed on iPhone 8 with 1.9 (19.03.25.21). I have tried folders re-order between iPhone and Linux. @srirambv - In iPhone after bookmarks folder re-order color of folder changes is that expected?

iPhone:
Bookmarks folders reorder

Linux:
image

Verified passed with 1.9 (19.03.25.21) on iPad 5th Gen - reordering occurred as expected. I did encounter bookmark folder colors (noted below in #860 (comment))

Verified passed on 1.9 (19.03.25.21) on iPhone SE

  • Verification passed on iPhone 6/iPhone 7+ and iPad Pro all running 1.9(19.3.25.21)

@iccub
Copy link
Contributor

iccub commented Mar 27, 2019

@GeetaSarvadnya The folder color goes away after closing and opening bookmark panel again, right?
If so, the color bug is related to #986

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants