Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bookmark sync changes are not shown if bookmark hanger is open #986

Closed
srirambv opened this issue Mar 18, 2019 · 1 comment
Closed

Bookmark sync changes are not shown if bookmark hanger is open #986

srirambv opened this issue Mar 18, 2019 · 1 comment
Labels
bug priority/P4 Planned work. We expect to get to it "soon". QA/Yes release/not-blocking release-notes/exclude
Milestone
1.9

Comments

@srirambv
Copy link
Contributor

Description:

Bookmark sync changes are not shown if bookmark hanger is open

Steps to Reproduce

  1. Create sync chain between two devices (iOS-iOS)
  2. Ensure bookmarks sync between devices
  3. Keep bookmark hanger open in one device and move bookmarks/edit bookmark name and reorder on the other device
  4. Changes are sync'd but not shown on the device where bookmark hanger is open
  5. Close and reopen bookmark tray, all changes are shown

Actual result:
Bookmark sync changes are not shown if bookmark hanger is open

Expected result:
Should show changes without having to close bookmark tray

Reproduces how often: [Easily reproduced, Intermittent Issue]
Fairly easy

Brave Version:
1.9

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

#772 (comment)
@srirambv srirambv added this to the 1.10 milestone Mar 18, 2019
@jhreis jhreis added bug and removed bug/ux labels Mar 19, 2019
@iccub iccub removed their assignment Mar 19, 2019
@iccub iccub mentioned this issue Mar 27, 2019
Closed
iccub added a commit to iccub/brave-ios that referenced this issue Mar 28, 2019
@iccub
Fix brave#1010: Crash when moving bookmarks between folders.
02b223e 
Fix brave#986: Set correct parent uuid before updating sync orders.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 28, 2019
@iccub
Fix brave#1010: Crash when moving bookmarks between folders.
02605b3 
Fix brave#986: Set correct parent uuid before updating sync orders.
iccub added a commit to iccub/brave-ios that referenced this issue Mar 28, 2019
@iccub
Fix brave#1010: Crash when moving bookmarks between folders.
015e603 
Fix brave#986: Set correct parent uuid before updating sync orders.
@jhreis jhreis closed this as completed in a742561 Mar 28, 2019
@srirambv srirambv modified the milestones: 1.10, 1.9 Mar 28, 2019
@srirambv
Copy link
Contributor Author

  • Verification passed on iPhone 7/6 and iPad Pro
    • Verified bookmarks/folder reorder sync's without having to close bookmarks tray
    • Verified renaming bookmark/folder on one device sync'd on other device without having to close bookmark tray

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug priority/P4 Planned work. We expect to get to it "soon". QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
3 participants
@jhreis @iccub @srirambv