Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6888: Remove object freezing for XHR send patches #6907

Closed
wants to merge 2 commits into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Feb 8, 2023

Summary of Changes

This pull request fixes #6888

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

With shields on:

Steps 1

  1. Go to the following page: https://gql.twitch.tv/149e9513-01fa-4fb0-aad4-566afd725d1b/2d206a39-8ed7-437e-a3be-862e0f06eea3/fp
  2. If the page doesn't freeze, delete all cookies on that page
  3. Reload the page
  4. Should not freeze the tab

Steps 2

  1. Reset the simulator or delete the brave application
  2. Install brave and run it
  3. Go to the following page: https://gql.twitch.tv/149e9513-01fa-4fb0-aad4-566afd725d1b/2d206a39-8ed7-437e-a3be-862e0f06eea3/fp
  4. Should not freeze the tab

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner February 8, 2023 13:16
@kylehickinson
Copy link
Collaborator

Closing in favor of #6910, please re-open a new PR with code-smell specific changes if needed still :)

@cuba cuba deleted the js/6888-fix-issues-with-twitch branch April 18, 2023 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading some websites hanging because of a Intermittent error caused by injected scripts
2 participants