Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6888: Fixes __firefox__ overrides to not override themselves #6910

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

Brandon-T
Copy link
Collaborator

Summary of Changes

  • Fixes firefox overrides to not override themselves
  • Recursive overriding can cause issues on twitch which overrides XMLHttpRequest.prototype.send and tries to do its own security on top of our own.

This pull request fixes #6888

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Visit twitch.tv
  2. Refresh the page
  3. Twitch should NOT freeze! The page should refresh and load just fine.

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.48 milestone Feb 8, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner February 8, 2023 20:56
@Brandon-T Brandon-T self-assigned this Feb 8, 2023
@Brandon-T Brandon-T removed the QA/Yes label Feb 8, 2023
@Brandon-T Brandon-T merged commit 86447c8 into development Feb 8, 2023
@Brandon-T Brandon-T deleted the bugfix/sec-overrides branch February 8, 2023 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading some websites hanging because of a Intermittent error caused by injected scripts
2 participants