Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable user namespaces #10

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Enable user namespaces #10

merged 3 commits into from
Sep 17, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Sep 13, 2019 •
edited
Loading

Fixes brave/brave-browser#5502.

Tested on Debian:

  1. Ensure that user namespaces are disabled:
$ sysctl kernel.unprivileged_userns_clone
kernel.unprivileged_userns_clone = 0
  1. Install the brave-browser package using the official instructions.
  2. Confirm that Brave crashes on startup.
  3. Install the updated brave-keyring package (version 1.4).
  4. Confirm that Brave starts up fine.

@fmarier fmarier requested a review from bkero September 13, 2019 23:15
@fmarier fmarier self-assigned this Sep 13, 2019
@fmarier
Copy link
Member Author

fmarier commented Sep 16, 2019

I also tested the new brave-keyring package on Ubuntu (where user namespaces are enabled by default) to confirm that this change doesn't break on other platforms.

@fmarier fmarier merged commit 35c0cf1 into brave:master Sep 17, 2019
@fmarier fmarier deleted the enable-user-namespaces branch September 17, 2019 22:36
@fmarier fmarier mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkero bkero bkero approved these changes

Assignees

@fmarier fmarier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable user namespaces in the Debian package
2 participants
@fmarier @bkero