Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Changing tipsMigrationAlert -> boxAlert, adding Ads variant #427

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 14, 2019

Related issue: brave/brave-browser#2562

The tips alert component was too specific, now it is more general, and we can add a flavor for auto contribute now if needed.

Screen Shot 2019-03-13 at 6 13 12 PM

Screen Shot 2019-03-13 at 6 13 17 PM

https://brave-ui-dmhift3yt.now.sh

Changes

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml ryanml merged commit d364c5e into master Mar 20, 2019
@ryanml ryanml deleted the alert branch March 20, 2019 19:09
ryanml added a commit that referenced this pull request Mar 21, 2019
Changing tipsMigrationAlert -> boxAlert, adding Ads variant
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants