Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorkaroundNewWindowFlash study (50% nightly) #1178

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add WorkaroundNewWindowFlash study (50% nightly) #1178

merged 2 commits into from
Aug 13, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Aug 12, 2024

Resolves #1177

Copy link
Contributor

github-actions bot commented Aug 12, 2024

✅ Test Seed Generated Successfully

Seed Details

Parameter Value
Version pull/1178@7d5bec8a5cbf7c5386bea59bb57c6c22b53da256
Uploaded Tue, 13 Aug 2024 12:42:53 GMT
PR commit 736206c
Base commit a189a97
Merge commit 7d5bec8
Serial number 760681755b77b9cba884e4bb386ab724

Applying the test seed

  1. Desktop: Launch the browser with --variations-pr=1178.
    Android: Set the command line to --variations-pr=1178 in debug menu, restart the browser.
    iOS: Set Variations PR to 1178 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

@goodov goodov marked this pull request as ready for review August 12, 2024 08:06
@goodov goodov requested a review from a team as a code owner August 12, 2024 08:06
@kjozwiak
Copy link
Member

Nightly verification(s)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.70.66 Chromium: 128.0.6613.27 (Official Build) nightly (64-bit)
-- | --
Revision | 667a3d64bcaa33f50347e567971f37eeb76758aa
OS | Windows 11 Version 23H2 (Build 22631.3958)

WorkaroundNewWindowFlash:Enabled Case - PASSED

  • launched 1.70.66 Chromium: 128.0.6613.27 using brave.exe --enable-logging=stderr --variations-pr=1178
  • relaunched once again using brave.exe --enable-logging=stderr --variations-pr=1178
  • ensured that pull/1178@7d5bec8a5cbf7c5386bea59bb57c6c22b53da256 is appearing under brave://version
  • ensured that WorkaroundNewWindowFlash:Enabled via brave://version
  • ensured that minimizing/maximizing the browser didn't create a white flash when the window is being restored
  • ensured that opening Brave doesn't produce a white flash
workingExample.mp4

WorkaroundNewWindowFlash:Default Case - PASSED

  • launched 1.70.66 Chromium: 128.0.6613.27 using brave.exe --enable-logging=stderr --variations-pr=1178
  • relaunched once again using brave.exe --enable-logging=stderr --variations-pr=1178
  • ensured that pull/1178@7d5bec8a5cbf7c5386bea59bb57c6c22b53da256 is appearing under brave://version
  • ensured that WorkaroundNewWindowFlash:Enabled via brave://version
  • ensured that minimizing/maximizing the browser produced a white flash when the window is being restored
  • ensured that opening Brave produced a white flash
brokenExample.mp4

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #1178 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit fcf9b8a Aug 13, 2024
7 checks passed
@kjozwiak kjozwiak deleted the issues/1177 branch August 13, 2024 16:03
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2024
1.70.x is now Release, so we can continue rolling this feature. It's
already enabled by default in Nightly and Beta.

Related #1178
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2024
1.70.x is now Release, so we can continue rolling this feature. It's
already enabled by default in Nightly and Beta.

Related #1178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable BraveWorkaroundNewWindowFlash in nightly
2 participants