Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BraveWorkaroundNewWindowFlash 25% Release #1213

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Sep 20, 2024

1.70.x is now Release, so we can continue rolling this feature. It's already enabled by default in Nightly and Beta.

Related #1178

Copy link
Contributor

github-actions bot commented Sep 20, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1213.
    Android: Set the command line to --variations-pr=1213 in debug menu, restart the browser.
    iOS: Set Variations PR to 1213 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1213@7475e4750dd1e1bfbca5e216549857553f9fa956
Uploaded Fri, 20 Sep 2024 06:30:35 GMT
PR commit ad3d0c2
Base commit e7bfa3e
Merge commit 7475e47
Serial number 9eebfedca7052689e4c1d9ae3a022e6d

@goodov goodov marked this pull request as ready for review September 20, 2024 06:31
@goodov goodov requested a review from a team as a code owner September 20, 2024 06:31
@kjozwiak
Copy link
Member

Release verification(s)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.70.117 Chromium: 129.0.6668.59 (Official Build) (64-bit)
-- | --
Revision | 5d4da8332eb061f79bb47ec5b0bf595600fdcd55
OS | Windows 11 Version 23H2 (Build 22631.4169)

WorkaroundNewWindowFlash:Enabled Case - PASSED

  • launched 1.70.117 Chromium: 129.0.6668.59 using brave.exe --enable-logging=stderr --variations-pr=1178
  • relaunched once again using brave.exe --enable-logging=stderr --variations-pr=1178
  • ensured that pull/1213@7475e4750dd1e1bfbca5e216549857553f9fa956 is appearing under brave://version
  • ensured that WorkaroundNewWindowFlash:Enabled via brave://version
  • ensured that minimizing/maximizing the browser didn't create a white flash when the window is being restored
  • ensured that opening Brave doesn't produce a white flash

image

WorkaroundNewWindowFlash:Default Case - PASSED

  • launched 1.70.117 Chromium: 129.0.6668.59 using brave.exe --enable-logging=stderr --variations-pr=1178
  • relaunched once again using brave.exe --enable-logging=stderr --variations-pr=1178
  • ensured that pull/1213@7475e4750dd1e1bfbca5e216549857553f9fa956 is appearing under brave://version
  • ensured that WorkaroundNewWindowFlash:Disabled via brave://version
  • ensured that minimizing/maximizing the browser didn't create a white flash when the window is being restored
  • ensured that opening Brave doesn't produce a white flash

image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main approved 👍 QA has verified the PR on Release as per #1213 (comment). The above is already fixed via client side for both Nightly & BETA.

@kjozwiak kjozwiak self-requested a review September 24, 2024 17:21
@kjozwiak kjozwiak added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit ee4ac76 Sep 24, 2024
7 checks passed
@kjozwiak kjozwiak deleted the new-findow-flash-release branch September 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants