Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable aggressive fingerprinting mode in Nightly #866

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Disable aggressive fingerprinting mode in Nightly #866

merged 2 commits into from
Jan 17, 2024

Conversation

arthuredelstein
Copy link
Collaborator

Refers to #865

@arthuredelstein arthuredelstein requested a review from a team as a code owner January 13, 2024 04:21
@arthuredelstein arthuredelstein force-pushed the issues/865_main branch 2 times, most recently from c5b2f60 to 8d85bb1 Compare January 13, 2024 05:39
kjozwiak
kjozwiak approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main (staging). Once verified, we'll merge #867 into production.

@kjozwiak kjozwiak merged commit 1cf8738 into main Jan 17, 2024
5 checks passed
@kjozwiak kjozwiak deleted the issues/865_main branch January 17, 2024 19:26
@kjozwiak
Copy link
Member

kjozwiak commented Jan 18, 2024 •
edited
Loading

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

Windows x64 Verifications

Nightly - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.63.124 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
-- | --
Revision | e0864ffae4be8015ad75c2b344ab75c2eefb31a7
OS | Windows 11 Version 23H2 (Build 22631.3007)
  • downloaded/installed 1.63.124 Chromium: 121.0.6167.57 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
image image image

BETA - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.63.126 Chromium: 121.0.6167.57 (Official Build) beta (64-bit)
-- | --
Revision | 37cf1e839670a842970254b61cdd4ef63307c8f1
OS | Windows 11 Version 23H2 (Build 22631.3007)
  • downloaded/installed 1.63.126 Chromium: 121.0.6167.57 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image

Release - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.61.120 Chromium: 120.0.6099.234 (Official Build) (64-bit)
-- | --
Revision | 362207c81bff0740a8b6cff62dd91c6789f5698f
OS | Windows 11 Version 23H2 (Build 22631.3007)
  • downloaded/installed 1.61.120 Chromium: 120.0.6099.234 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image

@kjozwiak
Copy link
Member

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

Pixel 6 Android 14 Verifications

Nightly - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.64.2 Chromium: 121.0.6167.57 (Official Build) canary (64-bit)
--- | ---
Revision | 090e22fcb8520fb64937caf796f7aae8639113bf
OS | Android 14; Build/AP11.231215.007; 34; REL
  • downloaded/installed 1.64.2 Chromium: 121.0.6167.57 (standalone executable) and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
Screenshot_20240118-124740 Screenshot_20240118-124757 Screenshot_20240118-124811

BETA - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.63.126 Chromium: 121.0.6167.57 (Official Build) beta (64-bit)
--- | ---
Revision | 37cf1e839670a842970254b61cdd4ef63307c8f1
OS | Android 14; Build/AP11.231215.007; 34; REL
  • downloaded/installed 1.63.126 Chromium: 121.0.6167.57 (standalone executable) and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
Screenshot_20240118-125424 Screenshot_20240118-125454 Screenshot_20240118-125444

Release - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.61.120 Chromium: 120.0.6099.234 (Official Build) (64-bit)
--- | ---
Revision | 362207c81bff0740a8b6cff62dd91c6789f5698f
OS | Android 14; Build/AP11.231215.007; 34; REL
  • downloaded/installed 1.61.120 Chromium: 120.0.6099.234 (standalone executable) and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
Screenshot_20240118-130553 Screenshot_20240118-130608 Screenshot_20240118-130617

@kjozwiak kjozwiak mentioned this pull request Jan 18, 2024
Merged
@kjozwiak kjozwiak mentioned this pull request Mar 28, 2024
Merged
@kjozwiak kjozwiak mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
unverified-commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthuredelstein @kjozwiak