Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Use proper protocol string for comparisons
Browse files Browse the repository at this point in the history
Already covered by a lot of automated tests that are failing only in
0.18.x branch.  Example navigationBar tests lockIcon Shows insecure URL
icon.

Auditors: @bsclifton

Fix #10093
  • Loading branch information
bbondy committed Jul 26, 2017
1 parent 2e602b4 commit 639013e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/renderer/components/navigation/urlBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ class UrlBar extends React.Component {
const displayEntry = tabState.getVisibleEntry(state, activeTabId) || Immutable.Map()
const displayURL = tabState.getVisibleVirtualURL(state, activeTabId) || ''
const hostValue = displayEntry.get('host', '')
const protocol = displayEntry.get('protocol', '')
const protocol = (displayEntry.get('protocol', '')).split(':')[0]

const baseUrl = getBaseUrl(location)
const urlbar = activeFrame.getIn(['navbar', 'urlbar']) || Immutable.Map()
Expand Down

1 comment on commit 639013e

@bsclifton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++! 😄

Please sign in to comment.