Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

0.18.x: Lock icon not showing in URL bar #10093

Closed
cndouglas opened this issue Jul 22, 2017 · 1 comment
Closed

0.18.x: Lock icon not showing in URL bar #10093

cndouglas opened this issue Jul 22, 2017 · 1 comment

Comments

@cndouglas
Copy link

  • Did you search for similar issues before submitting this one?
    Yes.

  • Describe the issue you encountered:
    The "lock" icon is no longer showing in the URL bar. It worked fine in 0.17.x but stopped working in 0.18.x.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS 10.12.x

  • Brave Version (revision SHA):
    0.18.8 (32d8cf8)

  • Steps to reproduce:

    1. Open a new window.
    2. Go to github.com.
  • Actual result:
    The "search" icon is shown in the URL bar.

  • Expected result:
    The "lock" icon should be shown to indicate that the site is secure.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes.

  • Is this an issue in the currently released version?
    No.

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:

    1. Open a new window.
    2. Go to github.com.
    3. Make sure the "lock" icon is shown in the URL bar.
  • Screenshot if needed:

  • Any related issues:
    None.

@luixxiul luixxiul added this to the 0.18.x (Beta Channel) milestone Jul 23, 2017
bbondy added a commit that referenced this issue Jul 26, 2017
Already covered by a lot of automated tests that are failing only in
0.18.x branch.  Example navigationBar tests lockIcon Shows insecure URL
icon.

Auditors: @bsclifton

Fix #10093
@bbondy
Copy link
Member

bbondy commented Jul 26, 2017

fixed here
639013e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.