Merge pull request #11185 from bsclifton/fix-phantom-tab-crashes

Fix phantom tab crashes
brave · Sep 27, 2017 · 765a315 · bsclifton · Sep 27, 2017 · cezaraugusto
1 parent 1636e26
commit 765a315
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/app/renderer/components/tabs/tab.js b/app/renderer/components/tabs/tab.js
@@ -122,14 +122,16 @@ class Tab extends React.Component {
   }
 
   onDragStart (e) {
-    // showing up the sentinel while dragging leads to show the shadow
-    // of the next tab. See 10691#issuecomment-329854096
-    // this is added back to original size when onDrag event is happening
-    this.tabSentinel.style.width = 0
-
-    dnd.onDragStart(dragTypes.TAB, this.frame, e)
-    // cancel tab preview while dragging. see #10103
-    windowActions.setTabHoverState(this.props.frameKey, false, false)
+    if (this.frame) {
+      // showing up the sentinel while dragging leads to show the shadow
+      // of the next tab. See 10691#issuecomment-329854096
+      // this is added back to original size when onDrag event is happening
+      this.tabSentinel.style.width = 0
+
+      dnd.onDragStart(dragTypes.TAB, this.frame, e)
+      // cancel tab preview while dragging. see #10103
+      windowActions.setTabHoverState(this.props.frameKey, false, false)
+    }
   }
 
   onDrag () {
@@ -138,7 +140,9 @@ class Tab extends React.Component {
   }
 
   onDragEnd (e) {
-    dnd.onDragEnd(dragTypes.TAB, this.frame, e)
+    if (this.frame) {
+      dnd.onDragEnd(dragTypes.TAB, this.frame, e)
+    }
   }
 
   onDragOver (e) {

diff --git a/js/contextMenus.js b/js/contextMenus.js
@@ -378,6 +378,10 @@ function autofillTemplateInit (suggestions, frame) {
 }
 
 function tabTemplateInit (frameProps) {
+  if (!frameProps) {
+    return null
+  }
+
   const frameKey = frameProps.get('key')
   const tabId = frameProps.get('tabId')
   const template = [CommonMenu.newTabMenuItem(frameProps.get('tabId'))]
@@ -1211,8 +1215,11 @@ function onMainContextMenu (nodeProps, frame, tab, contextMenuType) {
 
 function onTabContextMenu (frameProps, e) {
   e.stopPropagation()
-  const tabMenu = Menu.buildFromTemplate(tabTemplateInit(frameProps))
-  tabMenu.popup(getCurrentWindow())
+  const template = tabTemplateInit(frameProps)
+  if (template) {
+    const tabMenu = Menu.buildFromTemplate(template)
+    tabMenu.popup(getCurrentWindow())
+  }
 }
 
 function onNewTabContextMenu (target) {