Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix phantom tab crashes #11185

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Fix phantom tab crashes #11185

merged 1 commit into from
Sep 27, 2017

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 27, 2017 •
edited
Loading

Add extra checks to ensure that a crash doesn't happen in an edge case with "phantom tab" (which has null frame)

Related to #11070

Fixes #11183

Auditors: @darkdh

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

See #11183

Reviewer Checklist:

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Merge Checklist:

  • Merge to 0.19.x
  • Merge to 0.20.x
  • Merge to master

@bsclifton
Add extra checks to ensure that a crash doesn't happen in an edge cas…
d0637f3 
…e with "phantom tab" (which has null frame)

Related to #11070

Fixes #11183

Auditors: @darkdh
@bsclifton bsclifton self-assigned this Sep 27, 2017
@bsclifton bsclifton requested a review from darkdh September 27, 2017 19:11
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Sep 27, 2017
darkdh
darkdh approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 4307e64 into brave:0.19.x Sep 27, 2017
@bsclifton bsclifton deleted the fix-phantom-tab-crashes branch September 27, 2017 21:43
bsclifton added a commit that referenced this pull request Sep 27, 2017
@bsclifton
Merge pull request #11185 from bsclifton/fix-phantom-tab-crashes
765a315 
Fix phantom tab crashes
@bsclifton bsclifton mentioned this pull request Sep 27, 2017
Closed
@bsclifton
Copy link
Member Author

0.19.x 4307e64
0.20.x 765a315
master 72f0312

@luixxiul luixxiul added the crash label Sep 28, 2017
@bsclifton bsclifton mentioned this pull request Sep 28, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this pull request Nov 9, 2017
@bsclifton @syuan100
Merge pull request brave#11185 from bsclifton/fix-phantom-tab-crashes
116245e 
Fix phantom tab crashes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@bsclifton bsclifton

Labels
crash
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @darkdh @luixxiul