Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
change noscript icon from button to span
Browse files Browse the repository at this point in the history
fix Part 1 of #8403

test plan:
1. disable scripts on a page
2. click noscript icon
3. open browser console. you should not see any CSP errors.
  • Loading branch information
diracdeltas committed Apr 19, 2017
1 parent 22dc2b2 commit 82e71d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/renderer/components/navigation/urlBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ class UrlBar extends React.Component {
!this.showNoScriptInfo
? null
: <span className={css(styles.noScriptContainer)}>
<button
<span
data-l10n-id='noScriptButton'
data-test-id='noScriptButton'
className={css(styles.noScriptButton)}
Expand Down

3 comments on commit 82e71d0

@darkdh
Copy link
Member

@darkdh darkdh commented on 82e71d0 Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy
Copy link
Member

@bbondy bbondy commented on 82e71d0 Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not marking this as a button is an accessibility regression, could you just do display: inline @diracdeltas ?

Please sign in to comment.