This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
change noscript icon from button to span
fix Part 1 of #8403 test plan: 1. disable scripts on a page 2. click noscript icon 3. open browser console. you should not see any CSP errors.
- Loading branch information
82e71d0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
82e71d0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
82e71d0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not marking this as a button is an accessibility regression, could you just do
display: inline
@diracdeltas ?