This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
various issues with noscript icon #8403
Labels
Milestone
Comments
cc @bsclifton. this should block release if it's in the built version of 0.15.0 and other people also have this bug. |
diracdeltas
changed the title
clicking on noscript icon throws CSP error
various issues with noscript icon
Apr 19, 2017
if i click on the noscript icon 3 times in a row, it stops toggling the popup after the 2nd click |
@diracdeltas I can't repro that in |
diracdeltas
added a commit
that referenced
this issue
Apr 19, 2017
fix Part 1 of #8403 test plan: 1. disable scripts on a page 2. click noscript icon 3. open browser console. you should not see any CSP errors.
@bsclifton pretty sure that issue was due to redux refactoring and i have a fix |
is anyone seeing the lock icon issue on a site other than twitter.com? i think it's due to the noscript twitter siteHack actually |
@diracdeltas I tried a few sites, can't repro the lock disappearing- |
reproduced here, SHA f4d52d1
|
not only twitter but google as well |
@cezaraugusto you can reproduce the CSP error, but does the lock icon disappear? |
diracdeltas
added a commit
that referenced
this issue
Apr 20, 2017
fix #8403 1. change noscript icon from button to span to fix CSP error 2. fix repeated toggling of noScriptInfo dialog 3. refactor to remove deprecated code and combine windowActions 4. increase noscript click area 5. fix security icon disappearing on twitter.com test plan: 1. disable scripts on twitter.com. the lock icon should not disappear 2. click noscript icon 3. open browser console. you should not see any CSP errors. 4. now click the noscript icon repeatedly. you should see the popup come up and disappear repeatedly.
bsclifton
pushed a commit
that referenced
this issue
Apr 20, 2017
fix #8403 1. change noscript icon from button to span to fix CSP error 2. fix repeated toggling of noScriptInfo dialog 3. refactor to remove deprecated code and combine windowActions 4. increase noscript click area 5. fix security icon disappearing on twitter.com test plan: 1. disable scripts on twitter.com. the lock icon should not disappear 2. click noscript icon 3. open browser console. you should not see any CSP errors. 4. now click the noscript icon repeatedly. you should see the popup come up and disappear repeatedly.
luixxiul
added
QA/test-plan-required
release-notes/exclude
QA/test-plan-specified
and removed
QA/test-plan-required
labels
Apr 20, 2017
This was referenced Apr 21, 2017
This was referenced Mar 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#8410 (comment)
click the noscript icon repeatedly and the popup doesn't show up after the first time.
when noscript is enabled, twitter.com is missing the lock icon:
the clickable area should be increased
The text was updated successfully, but these errors were encountered: