This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix various noscript issues #8410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #8403 1. change noscript icon from button to span to fix CSP error 2. fix repeated toggling of noScriptInfo dialog 3. refactor to remove deprecated code and combine windowActions 4. increase noscript click area 5. fix security icon disappearing on twitter.com test plan: 1. disable scripts on twitter.com. the lock icon should not disappear 2. click noscript icon 3. open browser console. you should not see any CSP errors. 4. now click the noscript icon repeatedly. you should see the popup come up and disappear repeatedly.
bsclifton
reviewed
Apr 20, 2017
| @@ -119,7 +120,7 @@ module.exports.siteHacks = { | |||
| onBeforeSendHeaders: function(details) { | |||
| if (details.requestHeaders.Referer && | |||
| details.requestHeaders.Referer.startsWith('https://twitter.com/') && | |||
| details.url.startsWith('https://mobile.twitter.com/')) { | |||
| details.url.startsWith(appConfig.noScript.twitterRedirectUrl)) { | |||
8 tasks
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this pull request
Nov 9, 2017
by replacing form with div. Input element does not have to have form as a parent. Closes brave#8457 Follow-up to brave#8410 Auditors: @cezaraugusto Test Plan: 1. Run `npm run test -- --grep='can selectively allow scripts'` 2. disable scripts on twitter.com. the lock icon should not disappear 3. click noscript icon 4. open browser console. you should not see any CSP errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8403
test plan:
git rebase -ito squash commits (if needed).Test Plan: