Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Replace span with BrowserButton on urlbar.js, etc. #11110

Merged
merged 2 commits into from
Sep 24, 2017
Merged

Replace span with BrowserButton on urlbar.js, etc. #11110

merged 2 commits into from
Sep 24, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 23, 2017

by replacing form with div. Input element does not have to have form as a parent.

Closes #8457
Closes #11111
Follow-up to #8410

Auditors: @cezaraugusto

Test Plan for #8457:

  1. Run npm run test -- --grep='can selectively allow scripts'
  2. disable scripts on twitter.com. the lock icon should not disappear
  3. click noscript icon
  4. open browser console. you should not see any CSP errors.

Test Plan for #11111

  1. Open brave.com
  2. Enable NoScript
  3. Enable an extension
  4. Make sure NoScript button, the extension button, and publisher button is not draggable

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

by replacing form with div. Input element does not have to have form as a parent.

Closes #8457
Follow-up to #8410

Auditors: @cezaraugusto

Test Plan:
1. Run `npm run test -- --grep='can selectively allow scripts'`
2. disable scripts on twitter.com. the lock icon should not disappear
3. click noscript icon
4. open browser console. you should not see any CSP errors.
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 23, 2017
@luixxiul luixxiul self-assigned this Sep 23, 2017
@codecov-io
Copy link

codecov-io commented Sep 23, 2017

Codecov Report

Merging #11110 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11110      +/-   ##
==========================================
- Coverage    53.4%   53.35%   -0.05%     
==========================================
  Files         251      251              
  Lines       21760    21760              
  Branches     3405     3405              
==========================================
- Hits        11620    11611       -9     
- Misses      10140    10149       +9
Flag Coverage Δ
#unittest 53.35% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/common/browserButton.js 69.04% <ø> (ø) ⬆️
.../renderer/components/navigation/publisherToggle.js 98.36% <ø> (ø) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.45% <0%> (-0.31%) ⬇️

Closes #11111
Requires #10951 to make the shield button non-draggable

Auditors: @cezaraugusto

Test Plan:
1. Open brave.com
2. Enable NoScript
3. Enable an extension
4. Make sure NoScript button, the extension button, and publisher button is not draggable
@luixxiul luixxiul changed the title Replace span with BrowserButton on urlbar.js Replace span with BrowserButton on urlbar.js, etc. Sep 23, 2017
@luixxiul luixxiul merged commit 98b430b into brave:master Sep 24, 2017
@luixxiul luixxiul deleted the fix-noScriptButton branch September 24, 2017 02:33
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants