Merge pull request #5473 from brave/fix/reconcile-notification-add-di…

…smiss To "Review sites" notification add button to Dismiss
brave · Nov 8, 2016 · b926d73 · b926d73
2 parents 65b99f6 + 28e2d8d
commit b926d73
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/extensions/brave/locales/en-US/app.properties b/app/extensions/brave/locales/en-US/app.properties
@@ -169,6 +169,7 @@ flashExpirationText=Approvals reset 7 days after last visit.
 addFundsNotification=Your Brave Payments account is waiting for a deposit.
 reconciliationNotification=Good news! Brave will pay your favorite publisher sites in less than 24 hours.
 reviewSites=Review your chosen sites
+dismiss=Dismiss
 addFunds=Add funds
 notificationPasswordWithUserName=Would you like Brave to remember the password for {{username}} on {{origin}}?
 notificationPassword=Would you like Brave to remember your password on {{origin}}?

diff --git a/app/ledger.js b/app/ledger.js
@@ -333,7 +333,8 @@ if (ipc) {
       }
     } else if (message === reconciliationMessage) {
       appActions.hideMessageBox(message)
-      if (win) {
+      // buttonIndex === 1 is Dismiss
+      if (buttonIndex === 0 && win) {
         win.webContents.send(messages.SHORTCUT_NEW_FRAME,
           'about:preferences#payments', { singleFrame: true })
       }
@@ -1532,7 +1533,8 @@ const showNotificationReviewPublishers = () => {
     greeting: locale.translation('updateHello'),
     message: reconciliationMessage,
     buttons: [
-      {text: locale.translation('reviewSites'), className: 'primary'}
+      {text: locale.translation('reviewSites'), className: 'primary'},
+      {text: locale.translation('dismiss')}
     ],
     options: {
       style: 'greetingStyle',

diff --git a/app/locale.js b/app/locale.js
@@ -205,6 +205,7 @@ var rendererIdentifiers = function () {
     'notificationTryPayments',
     'notificationTryPaymentsYes',
     'prefsRestart',
+    'dismiss',
     'yes',
     'no',
     'noThanks',