This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
To "Review sites" notification add button to Dismiss #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because you should always be able to dismiss a notification. Auditors: @bsclifton Test Plan: (Similar to plan for #5296) 1. Trigger the "Payment in 24 hours, please review" notification. a. Update reconcileStamp to <24 hours from now b. Have sufficient funds; OR disable the sufficient funds conditional by adding false to ledger.js L1485 (showEnabledNotifications()) c. Change startup notification delay in ledger.js L484 from 15m to 5s 2. Open Brave and observe 24h review notification 3. Close Brave and reopen. Notification should not reappear. (Next 24h notification timestamp is set in Application Support/brave-development/session-store-1)
bsclifton
force-pushed
the
fix/reconcile-notification-add-dismiss
branch
from
7e8f145
to
28e2d8d
Compare
|
Looks good to me 😄 To folks reading this, this PR only allows for dismissal but doesn't disable notices (which is tracked with #5299) |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor – adds a button to dismiss this notification.
Auditors: @bsclifton
Test Plan:
(Similar to plan for #5296)
a. Update reconcileStamp to <24 hours from now
b. Update notification-reconcile-soon-timestamp to the past in Application Support/brave-development/session-store-1
c. Change startup notification delay in ledger.js L484 from 15m to 5s
d. Disable the sufficient funds conditional by adding false to ledger.js L1485 (showEnabledNotifications()) OR have sufficient funds
Image / Before
Image / After
