Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

To "Review sites" notification add button to Dismiss #5473

Merged
merged 1 commit into from
Nov 8, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/extensions/brave/locales/en-US/app.properties
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ flashExpirationText=Approvals reset 7 days after last visit.
addFundsNotification=Your Brave Payments account is waiting for a deposit.
reconciliationNotification=Good news! Brave will pay your favorite publisher sites in less than 24 hours.
reviewSites=Review your chosen sites
dismiss=Dismiss
addFunds=Add funds
notificationPasswordWithUserName=Would you like Brave to remember the password for {{username}} on {{origin}}?
notificationPassword=Would you like Brave to remember your password on {{origin}}?
Expand Down
6 changes: 4 additions & 2 deletions app/ledger.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ if (ipc) {
}
} else if (message === reconciliationMessage) {
appActions.hideMessageBox(message)
if (win) {
// buttonIndex === 1 is Dismiss
if (buttonIndex === 0 && win) {
win.webContents.send(messages.SHORTCUT_NEW_FRAME,
'about:preferences#payments', { singleFrame: true })
}
Expand Down Expand Up @@ -1532,7 +1533,8 @@ const showNotificationReviewPublishers = () => {
greeting: locale.translation('updateHello'),
message: reconciliationMessage,
buttons: [
{text: locale.translation('reviewSites'), className: 'primary'}
{text: locale.translation('reviewSites'), className: 'primary'},
{text: locale.translation('dismiss')}
],
options: {
style: 'greetingStyle',
Expand Down
1 change: 1 addition & 0 deletions app/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ var rendererIdentifiers = function () {
'notificationTryPayments',
'notificationTryPaymentsYes',
'prefsRestart',
'dismiss',
'yes',
'no',
'noThanks',
Expand Down