Add an option for no delay in tab preview timing

closes #8860
brave · Jan 24, 2018 · d7aa04f · d7aa04f
1 parent f1ddefb
commit d7aa04f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/app/common/constants/settingsEnums.js b/app/common/constants/settingsEnums.js
@@ -22,9 +22,9 @@ const bookmarksToolbarMode = {
 }
 
 const tabPreviewTiming = {
-  LONG: 2000,
-  NORMAL: 1000,
-  SHORT: 500
+  NONE: 50, // add a bit of delay to avoid flashing of unwanted previews
+  SHORT: 400,
+  LONG: 750
 }
 
 const tabCloseAction = {

diff --git a/app/extensions/brave/locales/en-US/preferences.properties b/app/extensions/brave/locales/en-US/preferences.properties
@@ -197,6 +197,7 @@ newTabHomePage=Home page
 newTabMode=A new tab shows
 newTabNewTabPage=Dashboard
 nextContribution=Next contribution:
+none=None
 nonVerifiedPublishers=Allow contributions to non-verified sites
 noPaymentHistory=No previous contributions
 normal=Normal
@@ -357,7 +358,7 @@ tabCloseActionLastActive=Select the last viewed tab
 tabCloseActionNext=Select the next tab
 tabCloseActionParent=Select its parent tab
 tableEmptyText=No table data.
-tabPreviewTiming=Time to wait before previewing a tab
+tabPreviewTiming=Tab Preview Delay
 tabs=Tabs
 tabSettings=Tab Settings
 tabsPerTabPage=Number of tabs per tab set:

diff --git a/app/renderer/components/preferences/tabsTab.js b/app/renderer/components/preferences/tabsTab.js
@@ -39,16 +39,16 @@ class TabsTab extends ImmutableComponent {
   get tabPreviewTimingOptions () {
     return [
       {
-        id: 'long',
-        action: tabPreviewTiming.LONG
-      },
-      {
-        id: 'normal',
-        action: tabPreviewTiming.NORMAL
+        id: 'none',
+        action: tabPreviewTiming.NONE
       },
       {
         id: 'short',
         action: tabPreviewTiming.SHORT
+      },
+      {
+        id: 'long',
+        action: tabPreviewTiming.LONG
       }
     ]
   }

diff --git a/js/constants/appConfig.js b/js/constants/appConfig.js
@@ -12,7 +12,7 @@ const isTest = process.env.NODE_ENV === 'test'
 
 const buildConfig = require('./buildConfig')
 const isProduction = buildConfig.nodeEnv === 'production'
-const {fullscreenOption, autoplayOption} = require('../../app/common/constants/settingsEnums')
+const {fullscreenOption, autoplayOption, tabPreviewTiming} = require('../../app/common/constants/settingsEnums')
 const Channel = require('../../app/channel')
 
 module.exports = {
@@ -153,7 +153,7 @@ module.exports = {
     'tabs.tabs-per-page': 20,
     'tabs.close-action': 'parent',
     'tabs.show-tab-previews': true,
-    'tabs.preview-timing': 1000,
+    'tabs.preview-timing': tabPreviewTiming.SHORT,
     'tabs.show-dashboard-images': true,
     'privacy.history-suggestions': true,
     'privacy.bookmark-suggestions': true,