Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make tab preview based on mouse idle time #8860

Closed
cezaraugusto opened this issue May 12, 2017 · 8 comments · Fixed by #9887 or #12832
Closed

Make tab preview based on mouse idle time #8860

cezaraugusto opened this issue May 12, 2017 · 8 comments · Fixed by #9887 or #12832
Assignees
@cezaraugusto
Labels
feature/tab-preview feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 12, 2017 •
edited
Loading

Test plan

See #9887

After #12823 please add the NO DELAY (current name) as a check too for undelayed tab previews. Thanks!!

Original issue description

Sometimes tab preview happen unintentionally if you go from urlbar to webview. Tab previews are based on RegExp that checks which element has hovered before current tab preview.

After taking #3271 this still seems to be the best approach currently but we need to cover other elements that were missing on initial implementation.
@cezaraugusto cezaraugusto added this to the 0.15.400 milestone May 12, 2017
@cezaraugusto cezaraugusto self-assigned this May 12, 2017
@cezaraugusto cezaraugusto mentioned this issue May 12, 2017
Closed
cezaraugusto added a commit that referenced this issue May 12, 2017
@cezaraugusto
Improve tab preview timing
33d596e 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
@cezaraugusto cezaraugusto mentioned this issue May 12, 2017
Closed
6 tasks
@srirambv
Copy link
Collaborator

Could the preview be only shown after x seconds of the mouse pointer being held over the tab itself. This way it would solve the unintentional preview while moving the cursor over tabs?

@cezaraugusto
Copy link
Contributor Author

I tried that but doing so undercovered the flickering tab issue we had a while ago. The new method is the same we had but covering more cases. Reviews more than welcome ;)

cezaraugusto added a commit that referenced this issue May 16, 2017
@cezaraugusto
Improve tab preview timing
fc9790a 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
@ivanstegic
Copy link

I'm sorry that this is not completely related, but is it possible to switch tab preview off completely? If not, I would like to suggest that as a feature and am happy to create the issue. Any knowledge about this?

@srirambv
Copy link
Collaborator

srirambv commented May 16, 2017 •
edited
Loading

I'm sorry that this is not completely related, but is it possible to switch tab preview off completely?

@ivanstegic there is an option under tabs in settings page to turn off tab preview. Just disable the switch and you won't see tab preivew

@ivanstegic
Copy link

@srirambv Oh!!!!! Thanks, I really appreciate it. :)

cezaraugusto added a commit that referenced this issue May 17, 2017
@cezaraugusto
Improve tab preview timing
1154bb3 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 18, 2017
@cezaraugusto
Improve tab preview timing
b6bf298 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
cd11cb6 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
9d337ee 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
7d4dab6 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
cabbc3e 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
37f38f5 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 23, 2017
@cezaraugusto
make tab preview based on idle mouse time
e87a615 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue May 26, 2017
@cezaraugusto
make tab preview based on idle mouse time
276fac0 
- Fix #8860
- Auditors: @bsclifton, @bradleyrichter
cezaraugusto added a commit that referenced this issue Jun 3, 2017
@cezaraugusto
make tab preview based on idle mouse time
3d87b1e 
- Fix #8860
- Auditors: @bsclifton
@alexwykoff alexwykoff modified the milestones: 0.19.x, 0.17.x (Frozen, only critical adds from here) Jun 12, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.18.x (Developer Channel), 0.19.x (Nightly Channel) Jun 21, 2017
@cezaraugusto
Copy link
Contributor Author

moving to 0.18.x as per last weekly triage meeting. Pls ask before moving out, thanks

cezaraugusto added a commit that referenced this issue Jul 6, 2017
@cezaraugusto
make tab previews based on mouse idle time
52bcf96 
- Auditors: @bridiver
- Fix #8860
@cezaraugusto cezaraugusto mentioned this issue Jul 6, 2017
Merged
8 tasks
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@cezaraugusto @dfperry5
make tab previews based on mouse idle time
7eced7c 
- Auditors: @bridiver, @bsclifton
- Fix brave#8860
- Fix brave#3271
@luixxiul luixxiul mentioned this issue Nov 7, 2017
Closed
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Jan 24, 2018 •
edited
Loading

Heads-up QA I'm re-opening after #12823. This will add a "no delay" (current name) option for users that don't want to wait for a tab preview.

Prior checked features aren't affected as we're only adding a new option but removing checks just in case.

@cezaraugusto cezaraugusto reopened this Jan 24, 2018
@cezaraugusto cezaraugusto mentioned this issue Jan 24, 2018
Merged
cezaraugusto added a commit that referenced this issue Jan 24, 2018
@cezaraugusto
Add an option for NO_DELAY in tab preview timing
61f704f 
closes #8860
cezaraugusto added a commit that referenced this issue Jan 24, 2018
@cezaraugusto
Add an option for none in tab preview timing
04a996e 
closes #8860
cezaraugusto added a commit that referenced this issue Jan 24, 2018
@cezaraugusto
Add an option for no delay in tab preview timing
7356f4d 
closes #8860
petemill pushed a commit that referenced this issue Jan 24, 2018
@cezaraugusto @petemill
Add an option for no delay in tab preview timing
d7aa04f 
closes #8860
petemill pushed a commit that referenced this issue Jan 24, 2018
@cezaraugusto @petemill
Add an option for no delay in tab preview timing
4b91dfe 
closes #8860
petemill pushed a commit that referenced this issue Jan 24, 2018
@cezaraugusto @petemill
Add an option for no delay in tab preview timing
b2db853 
closes #8860
This was referenced Jan 29, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 29, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/tab-preview feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
8 participants
@ivanstegic @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags