Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clipboard copies URL instead of text selected on webpage #10214

Closed
hp4k1h5 opened this issue Jul 31, 2017 · 7 comments · Fixed by #10419
Closed

Clipboard copies URL instead of text selected on webpage #10214

hp4k1h5 opened this issue Jul 31, 2017 · 7 comments · Fixed by #10419

Comments

@hp4k1h5
Copy link

hp4k1h5 commented Jul 31, 2017

Test plan

  1. Visit a site which has text you can select (ex: https://brave.com)
  2. Click into the URL bar. Ensure all text is selected (Ctrl + A or Cmd + A)
  3. Highlight text on the web page
  4. Copy selection using Ctrl + C / Cmd + C
  5. Paste into a text editor like Notepad or Sublime

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    copy and paste non-functioning, seems "stuck" on URL or other page feature

  • Platform (macOS sierra 10.12.5):

  • Brave Version (0.8.14):

  • Steps to reproduce:

    1. Visit a site which has text you can select (ex: https://brave.com)
    2. Click into the URL bar. Ensure all text is selected (Ctrl + A or Cmd + A)
    3. Highlight text on the web page
    4. Copy selection using Ctrl + C / Cmd + C
    5. Paste into a text editor like Notepad or Sublime
  • Actual result:
    pastes either page URL(which i never even copied!) or some other feature from the page (that i never copied), not the selected text.

  • Expected result:
    selected and copied text will paste

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?
    not sure

  • Can this issue be consistently reproduced?
    yes this is at least the second time i encounter this bug. i think a brave restart will mitigate this but it seems to be persistent

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@bsclifton
Copy link
Member

@hp4k1h5 thanks for the report! 😄 I have seen this (or something like it) too (and I know others have- cc: @bbondy, @jonathansampson)

@luixxiul luixxiul added this to the 0.22.x milestone Aug 2, 2017
@thbtmntgn
Copy link

Same problem for me on macOS Sierra 10.12.6 and Brave 0.8.14 !

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.22.x Aug 7, 2017
@bsclifton bsclifton modified the milestones: 0.18.x Hotfix, 0.21.x (Nightly Channel) Aug 7, 2017
@bsclifton bsclifton self-assigned this Aug 7, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 7, 2017

STR:
not working

  1. focus url bar (make sure that url is selected)
  2. copy something from the webview

working

  1. focus url bar
  2. place cursor at the end of the url bar
  3. copy something from the webview

@bsclifton
Copy link
Member

This works great in 0.17.19 but happens in all versions of 0.18.x (I went as far back as 0.18.1). Needs more investigation

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Aug 9, 2017
@bsclifton bsclifton changed the title copy paste malfunction Clipboard copies URL instead of text selected on webpage Aug 9, 2017
@bsclifton
Copy link
Member

bsclifton commented Aug 9, 2017

I went back through old versions of 0.18.x and found the commit in which this breaks:
6cf2098

If you grab this commit and then run the following:

rm -rf node_modules && npm install
CHANNEL=dev npm run build-package
CHANNEL=dev npm run build-installer

You can install that version of Brave (the DMG for example) and the bug is present. If you check out the prior commit and follow those same steps, it works.

@bsclifton
Copy link
Member

I used the above commit (6cf2098) and tried an earlier version of Muon (4.3.0 is the first which uses Chromium 60). This also fails

@darkdh darkdh self-assigned this Aug 9, 2017
@darkdh
Copy link
Member

darkdh commented Aug 10, 2017

We need to revert this
43e5541

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.