Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert "Revert "Remove old copy hack for macOS packaged builds"" #10419

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Aug 10, 2017

This reverts commit 43e5541.

fix #10214

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@darkdh darkdh added this to the 0.18.x Hotfix milestone Aug 10, 2017
@darkdh darkdh self-assigned this Aug 10, 2017
@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #10419 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10419      +/-   ##
==========================================
+ Coverage    53.8%   53.81%   +0.01%     
==========================================
  Files         238      238              
  Lines       21056    21051       -5     
  Branches     3259     3258       -1     
==========================================
  Hits        11329    11329              
+ Misses       9727     9722       -5
Flag Coverage Δ
#unittest 53.81% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
js/constants/messages.js 100% <ø> (ø) ⬆️
app/localShortcuts.js 24.44% <ø> (+2.44%) ⬆️
js/stores/windowStore.js 30.61% <100%> (ø) ⬆️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, works great! 😄 👍

@bsclifton bsclifton merged commit 4a21232 into master Aug 11, 2017
@bsclifton bsclifton deleted the 10214 branch August 11, 2017 00:02
bsclifton added a commit that referenced this pull request Aug 11, 2017
Revert "Revert "Remove old copy hack for macOS packaged builds""
bsclifton added a commit that referenced this pull request Aug 11, 2017
Revert "Revert "Remove old copy hack for macOS packaged builds""
bsclifton added a commit that referenced this pull request Aug 11, 2017
Revert "Revert "Remove old copy hack for macOS packaged builds""
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard copies URL instead of text selected on webpage
3 participants