Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide enpass & metamask for 0.19 #10232

Closed
alexwykoff opened this issue Aug 1, 2017 · 6 comments
Closed

Hide enpass & metamask for 0.19 #10232

alexwykoff opened this issue Aug 1, 2017 · 6 comments
Assignees
@bsclifton
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Aug 1, 2017 •
edited by bsclifton
Loading

Test plan

See #10246
@alexwykoff alexwykoff added this to the 0.19.x (Beta Channel) milestone Aug 1, 2017
@alexwykoff alexwykoff changed the title Hide metamask for 0.19 Hide enpass & metamask for 0.19 Aug 1, 2017
@bsclifton bsclifton mentioned this issue Aug 2, 2017
Merged
8 tasks
@luixxiul
Copy link
Contributor

luixxiul commented Aug 3, 2017

Note: when unhiding enpass, please close #7778.

@luixxiul luixxiul mentioned this issue Aug 3, 2017
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Aug 3, 2017

@alexwykoff / @bsclifton / @cezaraugusto would one of you mind explaining why those were hidden?

CC: @andrewalker

@bsclifton
Copy link
Member

bsclifton commented Aug 3, 2017 •
edited
Loading

We ultimately need to do tests with it and uncover any potential blockers. From what I last thought, Muon didn't have support (but I could be wrong- is there an issue in brave/muon?)

@alexwykoff why did we choose to hide this during triage?

@andrewalker
Copy link
Contributor

It's a bit confusing, since people reported it working with #7778, and in my tests it worked as well. Is it broken in a specific platform? Do we need unit tests for it?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Aug 5, 2017
@bsclifton
Copy link
Member

@andrewalker I'll bring up with our team to see if we can expedite. When we first release an extension, we want to make sure everything works as expected. We just haven't had enough time to properly test this yet on our side

@alexwykoff
Copy link
Contributor Author

@luixxiul it was triaged out due to resource constraints.

@bsclifton bsclifton removed the needs-info Another team member needs information from the PR/issue opener. label Aug 7, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bsclifton @dfperry5
Hide enpass & metamask
073ace5 
Fixes brave#10232

Auditors: @cezaraugusto

Test Plan:
1. Visit Preferences > Extensions and verify both extensions are not shown
2. Visit Preferences > Security and verify enpass is not shown
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Sep 20, 2017
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
6 participants
@andrewalker @alexwykoff @luixxiul @bsclifton @srirambv @LaurenWags