Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unhide the toggle of Enpass password manager #7778

Closed
luixxiul opened this issue Mar 18, 2017 · 26 comments
Closed

Unhide the toggle of Enpass password manager #7778

luixxiul opened this issue Mar 18, 2017 · 26 comments
Labels
feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 18, 2017 •
edited by jonathansampson
Loading

Describe the issue you encountered: #5097 (comment)

Seems like muon doesn't have support for this yet.

Here's steps that can be followed to ensure the extension will work: https://blog.brave.com/loading-chrome-extensions-in-brave/

I'll just hide the toggle for now.
@luixxiul luixxiul added this to the Backlog milestone Mar 18, 2017
@mcg
Copy link

mcg commented Apr 27, 2017

Sorry to bump this ticket, but wondering when this might be re-enabled? Enpass is one of the better cross platform password managers(that isn't Lastpass) and without integration, a pain to use with Brave.

@bsclifton
Copy link
Member

@mcg that's a great question-
If you are comfortable building from source, you can give it a shot by reverting 29a8223. When you launch, it will then be visible in Preferences > Security

@mcg
Copy link

mcg commented May 24, 2017

Finally had time to build with that change reverted. Seems to work great now, at least on macOS. No hangs as had been reported previously.

@submarine89
Copy link

Does anyone know what changed that allows it to work now?

@mcg
Copy link

mcg commented May 26, 2017

@submarine89 Was muon update since the original bug?

Have also built with the revert on Ubuntu(17.04) working well there as well.

@submarine89
Copy link

I don't know.

@mcg
Copy link

mcg commented Jun 8, 2017

Including a screenshot showing this working....
brave-enpass

@bsclifton
Copy link
Member

@mcg awesome! Is there a PR to re-enable this? Once we have a PR up, it should be trivial to merge 😄

andrewalker added a commit to andrewalker/browser-laptop that referenced this issue Jun 18, 2017
@andrewalker
Revert "Hide Enpass until it's supported in muon"
926b1c7 
This reverts commit 29a8223.

According to issue brave#7778, particularly the comment by @mcg, support for
Enpass is already working. So the option can be re-enabled.
andrewalker added a commit to andrewalker/browser-laptop that referenced this issue Jun 18, 2017
@andrewalker
Revert "Hide Enpass until it's supported in muon"
707883b 
This reverts commit 29a8223.

According to issue brave#7778, particularly the comment by @mcg, support for
Enpass is already working. So the option can be re-enabled.

Fixes brave#7778, brave#5097, brave#6984.
andrewalker added a commit to andrewalker/browser-laptop that referenced this issue Jun 18, 2017
@andrewalker
Revert "Hide Enpass until it's supported in muon"
02eac73 
This reverts commit 29a8223.

According to issue brave#7778, particularly the comment by @mcg, support for
Enpass is already working. So the option can be re-enabled.

Fixes brave#7778, fixes brave#5097, fixes brave#6984.
@andrewalker andrewalker mentioned this issue Jun 18, 2017
Merged
8 tasks
@luixxiul luixxiul modified the milestones: 0.19.x (Nightly Channel), Backlog Jun 23, 2017
@luixxiul luixxiul reopened this Aug 3, 2017
@luixxiul luixxiul mentioned this issue Aug 3, 2017
Closed
@luixxiul luixxiul removed this from the 0.19.x (Beta Channel) milestone Aug 3, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 3, 2017 •
edited
Loading

This was reopened as enpass has been hidden again. See: #10232

@mcg
Copy link

mcg commented Aug 3, 2017

Sigh... confirming this was removed again due to decrease coverage by 0.01% ?

@andrewalker andrewalker mentioned this issue Aug 3, 2017
Merged
8 tasks
@alexwykoff
Copy link
Contributor

@mcg it was triaged out due to a lack of resources.

@philip-ulrich
Copy link

Any idea on when this is coming back. I keep having to downgrade every restart back to 0.19.1.

@sudo-tee
Copy link

enpass is the only reason why I don't use brave in the moment. Do you know when it will be re-enabled ?

@bsclifton
Copy link
Member

cc: @davidtemkin @zentagonist

@luixxiul luixxiul mentioned this issue Sep 20, 2017
Closed
@luixxiul luixxiul mentioned this issue Oct 2, 2017
Closed
@luixxiul luixxiul mentioned this issue Oct 2, 2017
Merged
8 tasks
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Skip Vimium and Enpass on extensionsTest.js
4e06319 
Closes brave#11234
Related: brave#9531 brave#7778

Auditors:

Test Plan:
1. Run `npm run test -- --grep='about:extensions'`
@karlprieb
Copy link

Any update on this?

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@mikesackett85
Copy link

Also would like to see if there is an update on this?

@nawuko
Copy link

nawuko commented Jan 18, 2018

Any update? Is there a way to enable it even when its not 100% bug free? (Like an unsupported feature)

@geekgonecrazy
Copy link

geekgonecrazy commented Jan 18, 2018 •
edited
Loading

I tried via copying over extension by @jonathansampson suggestion.
twitter thread/result https://twitter.com/geekgonecrazy/status/948646337385558017

@cezaraugusto
Copy link
Contributor

I guess we're missing some chrome apis required to make it work but last time I checked @jonathansampson was looking closely at what's happening

@grand-lotus-iroh
Copy link

I too wish Enpass worked with Brave on Windows 10. I don't mind using Firefox but I would like to use Brave.

@eljuno
Copy link
Contributor

eljuno commented Mar 22, 2018

+1 from Twitter https://twitter.com/Ekei_Hong/status/976719797470707712

@fullspeedz
Copy link

Is there any news on this? Not having Enpass is the only thing stopping me from using brave.

@grand-lotus-iroh
Copy link

No, it's not available. Browser isn't ready for power-users.

@avesst
Copy link

avesst commented Apr 13, 2018

+1. Waiting for Enpass support before I can ditch Firefox in favor of Brave

@ghost
Copy link

ghost commented May 29, 2018

1 year later.... any news on this?
I want to ditch Chrome but without Enpass I cannot.

@bsclifton
Copy link
Member

bsclifton commented May 29, 2018 •
edited
Loading

Hi folks

There are challenges with our current extension support. Some extension APIs work great, some need work. This is the bottle neck for adding new extensions in today's product

We are shifting towards using the Chromium UI (dropping Muon, our electron fork) so that we'll have full extension support. You can view the project here:
https://github.com/brave/brave-browser

We also have a blog post with more details about this transition:
https://brave.com/development-plans-for-upcoming-release/

Because we're working on that, I think it's safe to say we won't be able to address Enpass support with this version of the browser (browser-laptop). I'll close this issue as wontfix since we won't fix it with this code, but stay tuned for the new Chromium UI (Brave Core)

@bsclifton bsclifton removed this from the Triage Backlog milestone May 29, 2018
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests