Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledgerTable with pinned sites does not have the orange border #10434

Closed
luixxiul opened this issue Aug 11, 2017 · 0 comments
Closed

ledgerTable with pinned sites does not have the orange border #10434

luixxiul opened this issue Aug 11, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 11, 2017

Test plan

#10435 (comment)


Describe the issue you encountered: ledgerTable with pinned sites does not have the orange border.

This is because I forgot to include borderCollapse: 'collapse' on ledgerTable.js to sortableTable.js on #10265.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Run npm run add-simulated-synopsis-visits 100
    2. Open about:preferences#payments
    3. Pin some sites
  • Actual result: the orange border does not appear on the table

  • Extra QA steps:

    1. Make sure the orange border appears on the table
  • Any related issues:

@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 11, 2017
@luixxiul luixxiul self-assigned this Aug 11, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
Fixes brave#10434
Follow-up to brave#10265

Auditors: @cezaraugusto

Test Plan:
1. Run `npm run add-simulated-synopsis-visits 100`
2. Open about:preferences#payments
3. Pin some sites
4. Make sure the orange border appears on the table
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.