Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enable border on sortableTable by default #10435

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Enable border on sortableTable by default #10435

merged 1 commit into from
Aug 15, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 11, 2017

Fixes #10434
Follow-up to #10265

Auditors: @cezaraugusto

Test Plan:

  1. Run npm run add-simulated-synopsis-visits 100
  2. Open about:preferences#payments
  3. Pin some sites
  4. Make sure the orange border appears on the table

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #10434
Follow-up to #10265

Auditors: @cezaraugusto

Test Plan:
1. Run `npm run add-simulated-synopsis-visits 100`
2. Open about:preferences#payments
3. Pin some sites
4. Make sure the orange border appears on the table
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 11, 2017
@luixxiul luixxiul self-assigned this Aug 11, 2017
@luixxiul luixxiul requested a review from cezaraugusto August 11, 2017 15:45
@codecov-io
Copy link

Codecov Report

Merging #10435 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10435   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         238      238           
  Lines       21051    21051           
  Branches     3258     3258           
=======================================
  Hits        11329    11329           
  Misses       9722     9722
Flag Coverage Δ
#unittest 53.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
app/renderer/components/common/sortableTable.js 58.65% <ø> (ø) ⬆️

@luixxiul luixxiul merged commit 46b16c5 into brave:master Aug 15, 2017
@luixxiul luixxiul deleted the fix-sortableTable-borderCollapse branch August 15, 2017 11:02
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants