Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Url bar autocomplete has duplicated entries #10826

Closed
NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Closed

Url bar autocomplete has duplicated entries #10826

NejcZdovc opened this issue Sep 6, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
automated-tests feature/autocomplete feature/URLbar QA/no-qa-needed release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:

  20) urlBar tests autocomplete suffix should clear when it is not a prefix match:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

  21) urlBar tests autocomplete press escape key "before each" hook for "does select the urlbar text":
     Error: element (".urlBarSuggestions li") still not existing after 10000ms
      at elements(".urlBarSuggestions li") - isExisting.js:46:17
      at isExisting(".urlBarSuggestions li") - waitForExist.js:67:22

  22) urlBar tests autocomplete highlight suggestions with tab autofills from selected suggestion:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

  23) urlBar tests autocomplete highlight suggestions autofills from selected suggestion:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

@diracdeltas can you please check if this is a problem in the test or we regressed
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 6, 2017
@NejcZdovc
Copy link
Contributor Author

related issue #9827

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes duplicated root domains
f11c610 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 7, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes duplicated root domains
d93dd7c 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 10, 2017
@NejcZdovc
Fixes duplicated root domains
b66f5a8 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
@ghost ghost added the sprint/1 label Sep 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 17, 2017
@NejcZdovc
Fixes duplicated root domains
2664db1 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 18, 2017
@NejcZdovc
Fixes duplicated root domains
83b3341 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Sep 18, 2017
@NejcZdovc
Merge pull request #10839 from NejcZdovc/hotfix/#10826-suggestions
c2874cc 
Fixes duplicated root domains
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests feature/autocomplete feature/URLbar QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @NejcZdovc