Fixes duplicated root domains

[NejcZdovc]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Resolves #10826
Resolves #9827

Auditors:

Test Plan: specified in #9827

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[codecov-io]

Codecov Report

Merging #10839 into master will increase coverage by 0.02%.
The diff coverage is 95%.

@@            Coverage Diff             @@
##           master   #10839      +/-   ##
==========================================
+ Coverage   54.21%   54.24%   +0.02%     
==========================================
  Files         249      249              
  Lines       21816    21836      +20     
  Branches     3395     3399       +4     
==========================================
+ Hits        11827    11844      +17     
- Misses       9989     9992       +3

Flag	Coverage Δ
#unittest	54.24% <95%> (+0.02%)	⬆️

Impacted Files	Coverage Δ
js/lib/urlutil.js	85.53% <100%> (+0.37%)	⬆️
app/common/lib/suggestion.js	68.46% <100%> (+0.11%)	⬆️
app/common/lib/siteSuggestions.js	89.62% <83.33%> (-0.3%)	⬇️

[NejcZdovc]

travis is passing now for all related tests

  20) urlBar tests autocomplete suffix should clear when it is not a prefix match:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

  21) urlBar tests autocomplete press escape key "before each" hook for "does select the urlbar text":
     Error: element (".urlBarSuggestions li") still not existing after 10000ms
      at elements(".urlBarSuggestions li") - isExisting.js:46:17
      at isExisting(".urlBarSuggestions li") - waitForExist.js:67:22

  22) urlBar tests autocomplete highlight suggestions with tab autofills from selected suggestion:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

  23) urlBar tests autocomplete highlight suggestions autofills from selected suggestion:
     Error: Promise was rejected with the following reason: timeout
      at elements("#urlInput") - getValue.js:18:17
      at getValue("#urlInput") - brave.js:523:23

[jonathansampson]

We should avoid doing multiple lookups.

let location = data.get('location') || ''
let partitionNumber = data.get('partitionNumber')
return location + (partitionNumber ? '|' + partitionNumber : '')

[NejcZdovc]

done

[bbondy]

nit: I think you can combine these into one regex to be faster:
.replace(/\/?#?$/, '')

[NejcZdovc]

Now I saw that it would be great to first remove # and then /, so that would links like https://tweetdeck.twitter.com/# become https://tweetdeck.twitter.com.

So old code would be changed to:

return url
      .replace(/#*$/, '') // remove trailing  #
      .replace(/\/*$/, '')  // remove trailing /

where we would remove trailing # and then check new string for trailing /

This is what I put together .replace(/((#?\/?)|(\/#?))$/, '')

@bbondy What do you think about new regex?