Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Create FlyoutDialog component #10977

Closed
luixxiul opened this issue Sep 16, 2017 · 1 comment
Closed

Create FlyoutDialog component #10977

luixxiul opened this issue Sep 16, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 16, 2017

Test plan

#10978 (comment)


Describe the issue you encountered: Create FlyoutDialog component.

See my comment here: #10933 (review)

Creating <FlyoutDialog> to remove commonStyles.flyoutDialog.

eg.

<Dialog ...>
 <FlyoutDialog custom={
   styles.siteInfo,
   this.props.isBlockedRunInsecureContent && styles.siteInfo_large
 }>
 ...
 </FlyoutDialog>
</Dialog>

By setting up the component CommonForm can be normalized as follows:

 class CommonForm extends ImmutableComponent {
   render () {
-    return <div className={css(
-      commonStyles.flyoutDialog,
-      styles.commonForm
-    )} {...this.props} />
+    return <FlyoutDialog custom={styles.commonForm}>
+      {this.props.children}
+    </FlyoutDialog>
   }
 }

You will be able to set up the components following:

FlyoutDialog -> CommonForm -> CommonFormHanger

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul self-assigned this Sep 21, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 24, 2017
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@ghost ghost removed this from the 0.21.x (Nightly Channel) milestone Sep 26, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
- Update commonForm components based on FlyoutDialog

Addresses #7114
Closes #10977

Auditors: @cezaraugusto @bsclifton

Test Plan
1. Open about:styles
2. Click `commonForms`
3. Make sure the common form dialog is properly styled
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Nov 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@cezaraugusto
Copy link
Contributor

reverted in #14162. Keeping closed as Aphrodite refactor is not made anymore

@bsclifton bsclifton removed this from the 0.23.x (Developer Channel) milestone May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants