Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor elements styled with .flyoutDialog class with Aphrodite #7114

Closed
luixxiul opened this issue Feb 7, 2017 · 1 comment
Closed

Refactor elements styled with .flyoutDialog class with Aphrodite #7114

luixxiul opened this issue Feb 7, 2017 · 1 comment
Assignees
@luixxiul
Labels
refactoring/aphrodite wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 7, 2017 •
edited
Loading

Describe the issue you encountered:
As .flyoutDialog is introduced to app/renderer/components/styles/commonStyles.js with PR #7107, these lines should be removed:

browser-laptop/less/forms.less

Lines 8 to 18 in 4fb5d5a

.flyoutDialog {
background-color: @toolbarBackground;
border-radius: @borderRadius;
box-shadow: 2px 2px 8px #3b3b3b;
color: #000;
font-size: 13px;
padding: 10px 30px;
position: absolute;
text-align: left;
top: @dialogTopOffset;
}

Still .flyoutDialog is used in almost all dialogs on forms.less, so we have to refactor them as well.
@luixxiul luixxiul added this to the Backlog milestone Feb 7, 2017
This was referenced Feb 7, 2017
Merged
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 10, 2017 •
edited
Loading

FYI .flyoutDialog is copied to commonStyle.js with PR #7172

@luixxiul luixxiul self-assigned this Apr 25, 2017
@luixxiul luixxiul mentioned this issue Sep 16, 2017
Merged
8 tasks
@luixxiul luixxiul removed this from the Backlog milestone Sep 18, 2017
cezaraugusto pushed a commit that referenced this issue Nov 21, 2017
@cezaraugusto
Add FlyoutDialog
32dca6f 
- Update commonForm components based on FlyoutDialog

Addresses #7114
Closes #10977

Auditors: @cezaraugusto @bsclifton

Test Plan
1. Open about:styles
2. Click `commonForms`
3. Make sure the common form dialog is properly styled
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
refactoring/aphrodite wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luixxiul @bsclifton