This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor ReleaseNotes with Aphrodite #7172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cezaraugusto thanks for reviewing. Based on your feedback, I removed the quotes. Also I changed |
Closes #7171 Auditors: Test Plan: 1. Test that updating using BRAVE_UPDATE_VERSION=0.8.3 env variable works correctly 2. Click "Details" 3. Check the design of the dialog
luixxiul
commented
Feb 14, 2017
| @@ -106,7 +106,8 @@ const globalStyles = { | |||
| aboutPageSectionPadding: '24px', | |||
| defaultTabPadding: '0 4px', | |||
| defaultIconPadding: '2px', | |||
There was a problem hiding this comment.
defaultIconPadding was rebased on master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Description
Closes #7171
Auditors: @cezaraugusto
git rebase -ito squash commits (if needed).Test Plan: