Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add notification after Brave app update for BAT Mercury #11021

Closed
davidtemkin opened this issue Sep 19, 2017 · 5 comments
Closed

Add notification after Brave app update for BAT Mercury #11021

davidtemkin opened this issue Sep 19, 2017 · 5 comments
Assignees
@bsclifton
Labels
feature/notificationbar feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@davidtemkin
Copy link

davidtemkin commented Sep 19, 2017 •
edited by luixxiul
Loading

Test plan

#11265 (comment)

For BAT Mercury, show a notification after update/relaunch, under the following circumstances:

  • That the user has enabled payments
  • That the user's (bitcoin) balance isn't zero

When these circumstances are true, Brave should show a notification banner saying "Your Brave wallet has been updated" [OK] [Learn More] -- Exact copy is TBD

The "OK" button should dismiss the notification.

The "Learn more" button should take the user to a page, content TBD, that explains the fact that the user's bitcoin has been converted to BAT.
@mrose17 mrose17 removed their assignment Sep 20, 2017
@mrose17
Copy link
Member

mrose17 commented Sep 20, 2017

just to be clear: the goal is to have a update/relaunch notification facility, which can, among other things be triggered on this event.

@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Sep 20, 2017
@NejcZdovc NejcZdovc removed their assignment Sep 26, 2017
@bsclifton
Copy link
Member

Notification to look like this:
image

@bsclifton
Copy link
Member

This is basically a newer version of #4847 (which was never done because there isn't a way to deep link to the backup modal)

@bsclifton bsclifton mentioned this issue Oct 3, 2017
Merged
12 tasks
@srirambv
Copy link
Collaborator

srirambv commented Oct 7, 2017

This should be shown when wallet is converted immediately after upgrade or after wallet is created. But only shows after the browser is restarted a second time after everything is done.

@bsclifton @NejcZdovc @mrose17

@NejcZdovc
Copy link
Contributor

this one is tracked here #11333

This was referenced Oct 9, 2017
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bsclifton @syuan100
Ledger notifications refactor and add new BTC=>BAT notification
7bac062 
Fixes brave#11021

Presents this one-time "Converted BTC to BAT" alert:
 - if payments are enabled
 - user has a positive balance
 - this is an existing profile (new profiles will have firstRunTimestamp matching btcToBatTimestamp)
 - notification has not already been shown yet

Includes a "learn more" link pointing to:
https://brave.com/faq-payments/#brave-payments

Has a possible security risk- the deep link allows URL hash to modify state (limited to boolean state variables on about:preferences)

Auditors: @NejcZdovc, @diracdeltas

Test Plan:
`npm run unittest -- --grep="ledger api unit tests"`
`npm run unittest -- --grep="ledgerReducer unit tests"`
`npm run unittest -- --grep="Preferences component"`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/notificationbar feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
9 participants
@mrose17 @kjozwiak @luixxiul @bsclifton @davidtemkin @NejcZdovc @bradleyrichter @srirambv @LaurenWags