Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Notification not shown after transition was triggered #11333

Closed
bsclifton opened this issue Oct 7, 2017 · 1 comment
Closed

Notification not shown after transition was triggered #11333

bsclifton opened this issue Oct 7, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 7, 2017 •
edited by luixxiul
Loading

Test plan

#11395 (comment)

Description

For the BAT Mercury launch we are planning to show a notification that the funds get transferred from BTC to BAT.

#11231 delivered most of this- the only problem is the notification is not shown. The state needed to show the notification is only triggered after the transition has started... however the only place where these are checked is during launch

Steps to Reproduce

  • Have a bitcoin wallet (ex: use 0.18.x)
  • Launch a BAT Mercury build using LEDGER_VERBOSE=true on command line
  • Verify transition is triggered (this starts the process; it takes a while)
  • Notice you are not shown alert
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Oct 7, 2017
@bsclifton bsclifton self-assigned this Oct 7, 2017
@NejcZdovc NejcZdovc mentioned this issue Oct 7, 2017
Closed
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton Oct 10, 2017
@NejcZdovc NejcZdovc mentioned this issue Oct 10, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
d9bd125 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
44800cd 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
5db3f82 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
58b402a 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
3e7bd2f 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc @bsclifton
Adds transition overlay
c7cbee1 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors: @bsclifton

Test Plan:
@kjozwiak
Copy link
Member

Using the STR from #11333 (comment), I went through the following verification under macOS 10.12.6 x64:

  • ensured that clicking on "Back Up Your New Wallet" opens about:preferences#payments?ledgerBackupOverlayVisible
  • ensured that clicking "Learn more" opens https://brave.com/faq-payments/#brave-payments and doesn't close the notification
  • ensured clicking on "Later" closes the notification

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Adds transition overlay
792e5f9 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors: @bsclifton

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @luixxiul @bsclifton @NejcZdovc @srirambv