Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Currency QR Code missing after upgrade #11338

Closed
srirambv opened this issue Oct 7, 2017 · 4 comments
Closed

Currency QR Code missing after upgrade #11338

srirambv opened this issue Oct 7, 2017 · 4 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards needs-info Another team member needs information from the PR/issue opener. priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 7, 2017 •
edited by luixxiul
Loading

Test plan

#11395 (comment)

Description

Currency QR Code missing after upgrade

Steps to Reproduce

  1. Set browser to 0.18.36 and enable payments
  2. Upgrade to 0.19.34
  3. Click add funds in payment
  4. Click on currencies button, QR code is missing for all available currencies

Actual result:

image

Expected result:
Should show the QR code
Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave 0.19.34
rev d87b7ca
Muon 4.4.25

Reproducible on current live release:

N/A

Additional Information

cc: @NejcZdovc
@srirambv srirambv added bug feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking labels Oct 7, 2017
@srirambv srirambv added this to the 0.19.x (Beta Channel) milestone Oct 7, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Oct 7, 2017

Reproduced by me as well.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 7, 2017 •
edited
Loading

@srirambv but after a while (few minutes) you see the correct data right?

@srirambv
Copy link
Collaborator Author

srirambv commented Oct 7, 2017

No have been using for about an hour and restarted twice but still no QR Code

@NejcZdovc NejcZdovc self-assigned this Oct 9, 2017
@NejcZdovc
Copy link
Contributor

@srirambv I just tried this scenario and I can't reproduce it. At the beginning there is blank QR, but after few minutes transition is done and everything is populated. If you still manage to reproduce it, please send me this profile, so that I can debug it.

@NejcZdovc NejcZdovc added needs-info Another team member needs information from the PR/issue opener. and removed release/blocking labels Oct 9, 2017
@NejcZdovc NejcZdovc mentioned this issue Oct 10, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc
Adds transition overlay
3e7bd2f 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Oct 10, 2017
@NejcZdovc @bsclifton
Adds transition overlay
c7cbee1 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors: @bsclifton

Test Plan:
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Adds transition overlay
792e5f9 
Resolves brave#11389
Resolves brave#11340
Resolves brave#11333
Resolves brave#11338

Auditors: @bsclifton

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards needs-info Another team member needs information from the PR/issue opener. priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@kjozwiak @luixxiul @NejcZdovc @srirambv