Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add 2 decimal places (rounded for display) to BAT wallet balance #11264

Closed
bradleyrichter opened this issue Oct 3, 2017 · 2 comments
Closed

Add 2 decimal places (rounded for display) to BAT wallet balance #11264

bradleyrichter opened this issue Oct 3, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
design A design change, especially one which needs input from the design team. feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Oct 3, 2017 •
edited by bsclifton
Loading

Test plan

  1. Launch Brave 0.19.x
  2. View all the dollar amounts- they should be rounded to two decimal places. (see picture)

Original issue description

image

The actual wallet balance may have 4 decimals but the display should be rounded to 2 decimals.

The monthly budget remains fixed.

CC @mrose17 @zentagonist
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/rewards labels Oct 3, 2017
@bradleyrichter bradleyrichter added this to the 0.19.x (Beta Channel) milestone Oct 3, 2017
@NejcZdovc NejcZdovc mentioned this issue Oct 4, 2017
Merged
8 tasks
@bsclifton bsclifton added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Oct 5, 2017
@ghost ghost added priority/P4 Minor loss of function. Workaround usually present. and removed priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. labels Oct 6, 2017
@ghost
Copy link

ghost commented Oct 6, 2017 •
edited by ghost
Loading

Updated the priority labels to reflect the guidelines from here:

  • P1 - Blocks development or testing. Product cannot run.
  • P2 - Crashes. Loss of data. Severe memory leak.
  • P3 - Major loss of function.
  • P4 - Minor loss of function. Workaround usually present.
  • P5 - Cosmetic. Spelling, copy, layout.

NejcZdovc added a commit that referenced this issue Oct 6, 2017
@NejcZdovc
Adds BAT support
5813411 
Resolves #9740
Resolves #10945
Resolves #11251 
Resolves #11264
Resolves #11285
Resolves #11289
Resolves #11292
Resolves #11293
@kjozwiak
Copy link
Member

Using the STR from #11264 (comment), went through the following verifications:

  • ensured that all the entries within the monthly budget are using two decimal places
  • ensured that the account balance uses two decimal places
  • ensured that the "pending funds" message is using two decimal places
  • ensured that the "balance" under "Add funds to your Brave Wallet" is using two decimal places

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Adds BAT support
f9990fd 
Resolves brave#9740
Resolves brave#10945
Resolves brave#11251 
Resolves brave#11264
Resolves brave#11285
Resolves brave#11289
Resolves brave#11292
Resolves brave#11293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
design A design change, especially one which needs input from the design team. feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @luixxiul @bsclifton @NejcZdovc @bradleyrichter @LaurenWags