-
Notifications
You must be signed in to change notification settings - Fork 975
Brave wallet backup key overflows #11292
Comments
this is not the correct value. We shouldn't be changing css, but we have problem with keys |
more info: current master is working correctly (d6447e8), problem is only Master: browser-laptop/app/browser/api/ledger.js Line 1563 in d6447e8
Problem is that logic changed in bat library. |
after talking with @mrose17 about it, this is new way of doing backup, so will fix css accordingly |
fixed with #11231 |
Added QA/checked as the workflow is changed to single key and this is obsolete |
the single key should not overflow anyway. |
Removed milestone because this screen was reworked- this is no longer valid |
Resolves brave#9740 Resolves brave#10945 Resolves brave#11251 Resolves brave#11264 Resolves brave#11285 Resolves brave#11289 Resolves brave#11292 Resolves brave#11293
Test plan
Backup your wallet
Description
Because the key 2 will get longer, the key overflow the modal.
Steps to Reproduce
Backup your wallet
Actual result:
The key overflows
Expected result:
It should be wrapped
Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
2ca8815
Reproducible on current live release:
Additional Information
The text was updated successfully, but these errors were encountered: